From owner-freebsd-current@FreeBSD.ORG Fri Nov 19 10:09:31 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8FA911065673; Fri, 19 Nov 2010 10:09:31 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com [209.85.216.175]) by mx1.freebsd.org (Postfix) with ESMTP id 2D6AE8FC16; Fri, 19 Nov 2010 10:09:30 +0000 (UTC) Received: by qyk31 with SMTP id 31so468013qyk.13 for ; Fri, 19 Nov 2010 02:09:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=rezOWqcltP3g05dhS44hCe3yhv+tFm0lz4AYBz/sb20=; b=aUFpzVh4YFp/m4BYGG6MCAjqfAQI++p2ipl/qanRbiT7y+1aNMtp2J+gbRKLQ+aPP3 Yd+cmWRkojA426VMVLUiRhMwycVxJoYqiJaTzH8U0yfOJgrzNfGiB5sYZpdt5UqBSddZ qQQPvtD6SXGm4HNDeqOqDewBcNFM3iE/k0CA0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=KSCpWS8Vt8ObfmCpwH2IP7v+nADYjdM3bMr86vJwNxJg7OLU81BWUsJojw+f6DtfM7 3N/MUBgWEQgqe6LhrlEO8SYHc/ZizpYGKLUjPjUppx6/TFg62NWUi3+J54w394wmLkYP /++4DR4eu4BlaCvSQeBb1wqBtdd9daKqBnkE0= MIME-Version: 1.0 Received: by 10.229.221.17 with SMTP id ia17mr1663225qcb.24.1290161369216; Fri, 19 Nov 2010 02:09:29 -0800 (PST) Received: by 10.229.69.135 with HTTP; Fri, 19 Nov 2010 02:09:24 -0800 (PST) In-Reply-To: <20101118231411.GA5121@freebsd.org> References: <20101118231411.GA5121@freebsd.org> Date: Fri, 19 Nov 2010 13:09:24 +0300 Message-ID: From: Sergey Kandaurov To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-current@freebsd.org Subject: Re: old references to vfs_mountroot_try() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2010 10:09:31 -0000 On 19 November 2010 02:14, Alexander Best wrote: > hi there, > > vfs_mountroot_try() seems to have been removed, yet the src still contains > three references to it: > > vfs_mount.c:386 > vfs_mount.c:723 > freebsd32_misc.c:2368 > So, what about just to rename those comments to reflect function name change? Index: sys/kern/vfs_mount.c =================================================================== --- sys/kern/vfs_mount.c (revision 215516) +++ sys/kern/vfs_mount.c (working copy) @@ -383,7 +383,7 @@ * Filter out MNT_ROOTFS. We do not want clients of nmount() in * userspace to set this flag, but we must filter it out if we want * MNT_UPDATE on the root file system to work. - * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try(). + * MNT_ROOTFS should only be set in the kernel in parse_mount(). */ uap->flags &= ~MNT_ROOTFS; @@ -720,7 +720,7 @@ * Filter out MNT_ROOTFS. We do not want clients of mount() in * userspace to set this flag, but we must filter it out if we want * MNT_UPDATE on the root file system to work. - * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try(). + * MNT_ROOTFS should only be set in the kernel in parse_mount(). */ uap->flags &= ~MNT_ROOTFS; Index: sys/compat/freebsd32/freebsd32_misc.c =================================================================== --- sys/compat/freebsd32/freebsd32_misc.c (revision 215516) +++ sys/compat/freebsd32/freebsd32_misc.c (working copy) @@ -2365,7 +2365,7 @@ * Filter out MNT_ROOTFS. We do not want clients of nmount() in * userspace to set this flag, but we must filter it out if we want * MNT_UPDATE on the root file system to work. - * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try(). + * MNT_ROOTFS should only be set in the kernel in parse_mount(). */ uap->flags &= ~MNT_ROOTFS; -- wbr, pluknet