From owner-svn-src-all@freebsd.org  Mon Jun  4 15:18:37 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AF082FEC548;
 Mon,  4 Jun 2018 15:18:37 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 234756C7A4;
 Mon,  4 Jun 2018 15:18:37 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w54FIYfJ096338;
 Mon, 4 Jun 2018 08:18:34 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w54FIYRZ096337;
 Mon, 4 Jun 2018 08:18:34 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201806041518.w54FIYRZ096337@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r334609 - head/usr.sbin/pmc
In-Reply-To: <201806040630.w546UaRJ005645@repo.freebsd.org>
To: Matt Macy <mmacy@freebsd.org>
Date: Mon, 4 Jun 2018 08:18:34 -0700 (PDT)
CC: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jun 2018 15:18:37 -0000

[ Charset UTF-8 unsupported, converting... ]
> Author: mmacy
> Date: Mon Jun  4 06:30:35 2018
> New Revision: 334609
> URL: https://svnweb.freebsd.org/changeset/base/334609
> 
> Log:
>   pmc filter: avoid spurious gcc uninitialized warning

Is it truely uninitialzized, or are you silencing a bogus warning,
this commit and the code does not make that clear, and that should
be made clear.

Thanks,
Rod
> 
> Modified:
>   head/usr.sbin/pmc/cmd_pmc_filter.c
> 
> Modified: head/usr.sbin/pmc/cmd_pmc_filter.c
> ==============================================================================
> --- head/usr.sbin/pmc/cmd_pmc_filter.c	Mon Jun  4 05:55:40 2018	(r334608)
> +++ head/usr.sbin/pmc/cmd_pmc_filter.c	Mon Jun  4 06:30:35 2018	(r334609)
> @@ -145,7 +145,7 @@ pmc_filter_handler(uint32_t *lwplist, int lwpcount, ui
>  	if ((ps = pmclog_open(infd)) == NULL)
>  		errx(EX_OSERR, "ERROR: Cannot allocate pmclog parse state: %s\n", strerror(errno));
>  
> -	pmccount = 0;
> +	eventcount = pmccount = 0;
>  	while (pmclog_read(ps, &ev) == 0) {
>  		if (ev.pl_type == PMCLOG_TYPE_INITIALIZE)
>  			memcpy(cpuid, ev.pl_u.pl_i.pl_cpuid, PMC_CPUID_LEN);
> 
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org