Date: Fri, 1 Apr 2011 16:03:55 -0400 From: Andrew Duane <aduane@juniper.net> To: Juli Mallett <jmallett@FreeBSD.org> Cc: "mips@freebsd.org" <mips@FreeBSD.org> Subject: RE: Blatant simple bug in Cavium SDK USB code? Message-ID: <AC6674AB7BC78549BB231821ABF7A9AEB52F1950C8@EMBX01-WF.jnpr.net> In-Reply-To: <BANLkTinsxZdGQfaNgav-acpP6hDQ9Ss%2BgQ@mail.gmail.com> References: <AC6674AB7BC78549BB231821ABF7A9AEB52F1950C5@EMBX01-WF.jnpr.net> <AC6674AB7BC78549BB231821ABF7A9AEB52F1950C7@EMBX01-WF.jnpr.net>, <BANLkTinsxZdGQfaNgav-acpP6hDQ9Ss%2BgQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This isn't even close to the only problem I'm having. I don't make it out o= f cvmx_usb_initialize at all. One of two things happens: 1) The code completes and device_probe returns ENXIO so the routine bails o= ut and USB doesn't work. 2) Something goes insane and I either get a load fault halfway through the = routine touching one of the USB registers (CVMX_USBCX_GAHBCFG I think), or = I get an instruction exception in some worker routine buried in the middle. Ouch indeed.... -- Andrew Duane Juniper Networks 978-589-0551 10 Technology Park Dr aduane@juniper.net Westford, MA 01886-3418 ________________________________________ From: juli@clockworksquid.com [juli@clockworksquid.com] On Behalf Of Juli M= allett [jmallett@FreeBSD.org] Sent: Friday, April 01, 2011 2:45 PM To: Andrew Duane Cc: mips@freebsd.org Subject: Re: Blatant simple bug in Cavium SDK USB code? Hey Andrew, On Fri, Apr 1, 2011 at 11:08, Andrew Duane <aduane@juniper.net> wrote: > > In the routine cvmx_usb_initialize in sys/contrib/octeon-sdk/cvmx-usb.c, = I'm pretty sure there's a silly little bug that really BADLY breaks the USB= driver for some of us. > > Near the top, after it finds board type and sets the clock type, as part = of the structure initialization, there is: > > memset(usb, 0, sizeof(usb)); > > Tell me that is not supposed to be: > > memset(usb, 0, sizeof(*usb)); > > The existing code only zeros 4/8 bytes, instead of the 23KB of the struct= ure. Ouch, nice catch. Is that the only thing keeping the USB driver from working for you? I thought it had rotted some behind other controller changes and also had some problems with stalls, but perhaps the culprit was initialization all along. I'll check in that fix soon, but would like to hear from you as to whether you have any additional fixes for USB (or even bugs to report.) I've BCC'd some Cavium people who will no doubt appreciate the bug report! Thanks, Juli.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AC6674AB7BC78549BB231821ABF7A9AEB52F1950C8>