From owner-freebsd-acpi@FreeBSD.ORG  Wed Dec  9 10:32:53 2009
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C665A1065672;
	Wed,  9 Dec 2009 10:32:53 +0000 (UTC)
	(envelope-from infofarmer@FreeBSD.org)
Received: from heka.cenkes.org (heka.cenkes.org [IPv6:2002:d056:e3f1::1])
	by mx1.freebsd.org (Postfix) with ESMTP id 872268FC13;
	Wed,  9 Dec 2009 10:32:53 +0000 (UTC)
Received: from amilo.cenkes.org (ppp91-77-236-58.pppoe.mtu-net.ru
	[91.77.236.58]) (Authenticated sender: sat)
	by heka.cenkes.org (Postfix) with ESMTPSA id 6D1412EE92;
	Wed,  9 Dec 2009 12:46:39 +0300 (MSK)
Date: Wed, 9 Dec 2009 13:32:49 +0300
From: Andrew Pantyukhin <infofarmer@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20091209103248.GP98273@pollux.cenkes.org>
References: <20091208060339.GK98273@pollux.cenkes.org>
	<200912080749.55710.jhb@freebsd.org>
	<20091208134913.GL98273@pollux.cenkes.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="B4IIlcmfBL/1gGOG"
Content-Disposition: inline
In-Reply-To: <20091208134913.GL98273@pollux.cenkes.org>
X-OS: FreeBSD 8.0-BETA1 amd64
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: freebsd-acpi@freebsd.org
Subject: Re: libi386/biosacpi.c - bad RSDP checksum search
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Dec 2009 10:32:53 -0000


--B4IIlcmfBL/1gGOG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Dec 08, 2009 at 04:49:13PM +0300, Andrew Pantyukhin wrote:
> Oops. I obviously made a wrong assumption. I'll try to confirm.

Yep, the good RSDP is found later.

So I think either a "bad checksum" should be followed by a "good
checksum" or it should only be printed if no good RSDP has been
found. Attached are a couple of alternative tiny patches.

Otherwise, a FAQ entry should be added to keep the mere mortals
like me from wondering about the error message. FWIW, it comes up
on many (most?) IBM System x machines.

--B4IIlcmfBL/1gGOG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="biosacpi.c.diff1"

Index: biosacpi.c
===================================================================
--- biosacpi.c	(revision 200054)
+++ biosacpi.c	(working copy)
@@ -129,6 +129,7 @@
 		printf("acpi: bad RSDP checksum (%d)\n", sum);
 		continue;
 	    }
+	    printf("acpi: good RSDP checksum (%d)\n", sum);
 	    return(rsdp);
 	}
     }

--B4IIlcmfBL/1gGOG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="biosacpi.c.diff2"

Index: biosacpi.c
===================================================================
--- biosacpi.c	(revision 200054)
+++ biosacpi.c	(working copy)
@@ -125,12 +125,12 @@
 	    sum = 0;
 	    for (idx = 0; idx < RSDP_CHECKSUM_LENGTH; idx++)
 		sum += *(cp + idx);
-	    if (sum != 0) {
-		printf("acpi: bad RSDP checksum (%d)\n", sum);
+	    if (sum != 0)
 		continue;
-	    }
 	    return(rsdp);
 	}
     }
+    if (sum != 0)
+	printf("acpi: no RSDP with good checksum found\n");
     return(NULL);
 }

--B4IIlcmfBL/1gGOG--