From owner-svn-src-all@freebsd.org Tue Mar 19 22:52:45 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E7586153E9B2; Tue, 19 Mar 2019 22:52:44 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (162-251-186-162.surfnetc.com [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 554FA72BBA; Tue, 19 Mar 2019 22:52:43 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id x2JMqfnl000196 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 19 Mar 2019 15:52:41 -0700 (PDT) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id x2JMqfeg000195; Tue, 19 Mar 2019 15:52:41 -0700 (PDT) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Tue, 19 Mar 2019 15:52:41 -0700 From: Gleb Smirnoff To: "Andrey V. Elsukov" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r345274 - in head: sbin/ipfw sys/conf sys/modules/ipfw_nat64 sys/netinet6 sys/netpfil/ipfw/nat64 Message-ID: <20190319225241.GS3562@FreeBSD.org> References: <201903181259.x2ICx94D013948@repo.freebsd.org> <20190318230943.GR3562@FreeBSD.org> <2eb41483-24b5-0711-3798-7bf53dd5e716@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2eb41483-24b5-0711-3798-7bf53dd5e716@FreeBSD.org> User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: 554FA72BBA X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.975,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Mar 2019 22:52:45 -0000 On Tue, Mar 19, 2019 at 10:45:11AM +0300, Andrey V. Elsukov wrote: A> > On Mon, Mar 18, 2019 at 12:59:09PM +0000, Andrey V. Elsukov wrote: A> > A> Author: ae A> > A> Date: Mon Mar 18 12:59:08 2019 A> > A> New Revision: 345274 A> > A> URL: https://svnweb.freebsd.org/changeset/base/345274 A> > A> A> > A> Log: A> > A> Update NAT64LSN implementation: A> > ... A> > A> o ConcurrencyKit and epoch(9) is used to make NAT64LSN lockless on fast path. A> > A> > Why did you create a separate epoch? All the pfil hooks already run at network A> > epoch. A> A> Hi, A> A> You did not specified, when you plan to merge you changes. I assume that A> you didn't plan to do that. :) Do you mean to stable/12? In that case better to add epochs with the merge rather than to head. -- Gleb Smirnoff