From owner-freebsd-testing@FreeBSD.ORG Wed Apr 2 18:07:05 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A8ED4D90; Wed, 2 Apr 2014 18:07:05 +0000 (UTC) Received: from mail-vc0-x22c.google.com (mail-vc0-x22c.google.com [IPv6:2607:f8b0:400c:c03::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 56B442CE; Wed, 2 Apr 2014 18:07:05 +0000 (UTC) Received: by mail-vc0-f172.google.com with SMTP id la4so835994vcb.17 for ; Wed, 02 Apr 2014 11:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=uWAiy2MHYclfASwTAZAitn8a+/u/0CT6/ftcI9ZlYkg=; b=ygLlTGjM9JlNE+dvWWUoo5F97IEce7j5IK+BzzePxIu6oFbNPNUP7kt9cX2uJ/M5Z0 f8scedaA8o3JWNXXicLBOZAGqWA7/6iqlo1ZuzG+cYSo7+5nY+2Q8IBaKp0skouuAwfn 6RVjUvPGNh937HGyGEHpK2bqOmXURdNEgTa5P340FAEte6HC+29dCofGVFpyscC+ubKL JlduMr+iGGlAi78abNZ+sAlaiH1DqboMcxKXC/2im+ipbRZVNthCawbd6dzEig7AQswx +p0WOH2IIFwE2RRQ5Ujo5KDapt7OdgoGna/n5FJs7DI2n3ein2MzqfFTsOcELy7ACKzW +bcw== MIME-Version: 1.0 X-Received: by 10.52.164.175 with SMTP id yr15mr2024177vdb.59.1396462024505; Wed, 02 Apr 2014 11:07:04 -0700 (PDT) Received: by 10.221.67.136 with HTTP; Wed, 2 Apr 2014 11:07:04 -0700 (PDT) In-Reply-To: References: <20140402085349.GA61802@x2.osted.lan> Date: Wed, 2 Apr 2014 11:07:04 -0700 Message-ID: Subject: Re: ATF work From: Garrett Cooper To: Alan Somers Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-testing@freebsd.org" , Peter Holm X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Apr 2014 18:07:05 -0000 (Just to fill in some context on some of the items here) On Wed, Apr 2, 2014 at 9:31 AM, Alan Somers wrote: ... > All of the files from NetBSD should have a $FreeBSD:$ tag alongside > the NetBSD tag. Yes, I should have added those. > lib/libc/tests/net/getaddrinfo/Makefile has some commented out code > that should be removed. Most likely code that didn't compile in my workspace. > So does lib/libc/tests/net/getaddrinfo/t_getaddrinfo.sh. Not sure, but it might have been code that was broken due to discrepancies between FreeBSD and NetBSD > Could lib/libc/tests/net/gen_ether_subr be converted to an awk script > by replacing the first line with "#!/usr/bin/awk -f" and removing the > invocation to awk? Then it would have the correct syntax highlighting > in editors. I try to avoid that without pushing the change up to NetBSD first as I tried to make as minimal changes as possible to make things work with FreeBSD without things blowing up. > lib/libc/tests/net/Makefile has one tested comment out with the > comment "test uses rump". Would it be possible instead to leave the > test in the build, but put "require.progs rump_server" in the relevant > test cases' heads? Probably carryover from NetBSD that should be pushed back to NetBSD. > It would be more idiomatic for lib/libc/tests/tls_dso/Makefile to > define a TESTSDIR variable and use that in the definitions of LIBDIR > and SHLIBDIR. Good catch; this should potentially be pushed back to NetBSD. > lib/libc/tests/gen/Makefile has several tests commented out. Several > of the comments are confusingly short (what does "XXX: F_MAXFD DNE" > mean)? And the "#ATF_TESTS+= posix_spawn" line should be deleted. DNE -> does not exist, e.g. it's a parameter/functionality that exists on NetBSD and doesn't exist on FreeBSD. (philosophical item) I'm not sure about the commented out lines for posix_spawn as this (again) is a mostly carryover from NetBSD. Whether or not it should persist with a better "descriptor" or should be deleted is a good idea. > lib/libc/tests/gen/posix_spawn/Makefile contains commented out code. Probably incompatibilities between FreeBSD and NetBSD. > lib/libc/tests/arch contains subdirectories that FreeBSD doesn't > support and never will, like Vax. They should be deleted. Good point. Agreed. > It's unfortunate that all of t_sha2 is disabled. I don't understand > the comment, either. Is it disabled just because FreeBSD doesn't have > sha384 functions? We have both sha1 and sha256 in libc. sha384 doesn't exist in FreeBSD; either the code should be adjusted and the adjustment should be contributed back to NetBSD, or leave it as-is. > lib/libc/tests/termios/Makefile has WARNS=4 commented out. Why is that? > > Some Makefiles define "MAN= ". It is more idiomatic to define "NOMAN=". Thanks! -Garrett