Date: Fri, 2 Nov 2012 12:21:31 +0100 From: Pietro Cerutti <gahr@FreeBSD.org> To: Joseph a Nagy Jr <jnagyjr1978@gmail.com> Cc: ports@freebsd.org, Chris Rees <utisoft@gmail.com> Subject: Re: tk85 Port Maintenance Message-ID: <20121102112131.GG90275@gahrfit.gahr.ch> In-Reply-To: <509162C9.9060701@gmail.com> References: <509121B3.3040307@gmail.com> <20121031135749.GC90275@gahrfit.gahr.ch> <50913253.3060700@gmail.com> <20121031152109.GD90275@gahrfit.gahr.ch> <CADLo83_VSLt5t31bJbu3-UCuGkNuNnnBEbMXWVd2fhvVwryP5g@mail.gmail.com> <20121031153958.GE90275@gahrfit.gahr.ch> <50915194.6010101@gmail.com> <20121031165507.GF90275@gahrfit.gahr.ch> <509162C9.9060701@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--WRT3RXLOp/bBMgTI
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 2012-Oct-31, 12:41, Joseph a Nagy Jr wrote:
> On 10/31/12 11:55, Pietro Cerutti wrote:
> > On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote:
> <snip>
> >> New diff[0], undoing some of the earlier changes even though portlint
> >> complains:
> >>
> >> portlint ~/port-maintenance/tk85/
> >> WARN: Makefile: unless this is a master port, COMMENT has to be set by
> >> "=3D", not by "?=3D".
> >=20
> > This *is* a master port, so it's ok to have COMMENT?=3D
> >=20
> >> WARN: Makefile: "LIB_DEPENDS" has to appear earlier.
> >=20
> > This should be fixed as portlint suggests.
> >=20
> >> WARN: Makefile: no port directory
> >> /usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is
> >> listed in LIB_DEPENDS.
> >=20
> > I would try and use USE_TCL instead of LIB_DEPENDS here
> >=20
> >> WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in
> >> Xft.2 unless it is really necessary.
> >=20
> > This should be fixed as portlint suggests.
> >=20
> >> 0 fatal errors and 4 warnings found.
> >>
> >> [0]: http://pastebin.com/apf1Y9H0
> >=20
> > I'll have a look at it on Friday, thanks!
> >=20
> >=20
>=20
> Going ahead to make those changes, old pastebin link is defunct.
>=20
> New diff with all changes:
> http://pastebin.com/iwhpXfcp
This won't apply, either. Could you provide a diff as dumped by svn diff
in tk85's directory?
--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org
PGP Public Key:
http://gahr.ch/pgp
--WRT3RXLOp/bBMgTI
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlCTrKwACgkQwMJqmJVx945dYACfQ3GwbXtCKdEHWGGm7kdPQGb1
x1EAnRAufgTM+rSnLZhv9Nmtj7/AGlEb
=yPXS
-----END PGP SIGNATURE-----
--WRT3RXLOp/bBMgTI--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121102112131.GG90275>