From owner-freebsd-hackers  Sat Sep 14 19:02:29 1996
Return-Path: owner-hackers
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id TAA23640
          for hackers-outgoing; Sat, 14 Sep 1996 19:02:29 -0700 (PDT)
Received: from Lapkin.RoSprint.ru (root@Lapkin.RoSprint.ru [193.232.88.150])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id TAA23635;
          Sat, 14 Sep 1996 19:02:23 -0700 (PDT)
Received: (from sandy@localhost) by Lapkin.RoSprint.ru (8.7.5/8.6.9) id GAA00358; Sun, 15 Sep 1996 06:02:17 +0400 (MSD)
From: Sandy Kovshov <sandy@Lapkin.RoSprint.ru>
Message-Id: <199609150202.GAA00358@Lapkin.RoSprint.ru>
Subject: sppp with cisco hdlc bug fix
To: freebsd-current@freebsd.org
Date: Sun, 15 Sep 1996 06:02:16 +0400 (MSD)
Cc: freebsd-hackers@freebsd.org
X-Mailer: ELM [version 2.4 PL24alpha5]
Content-Type: text
Sender: owner-hackers@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

 Hello guys,


 Here is little patch for bug in sppp pseudo driver with cisco hdlc protocol.
 I've found it when test Riscom/N2 card with Cisco. At unknown reason,
 Cisco send 20 byte packet (without ppp header) instead of 18 ;)
 With old version it cause line hangup on keepalive timeout.


Index: net/if_spppsubr.c
===================================================================
RCS file: /home/sandy/project/freebsd/cvs/src/sys/net/if_spppsubr.c,v
retrieving revision 1.13
diff -c -r1.13 if_spppsubr.c
*** if_spppsubr.c	1996/08/30 16:44:36	1.13
--- if_spppsubr.c	1996/09/15 01:46:31
***************
*** 848,854 ****
  	struct ifaddr *ifa;
  	struct ifnet *ifp = &sp->pp_if;
  
! 	if (m->m_pkthdr.len != CISCO_PACKET_LEN) {
  		if (ifp->if_flags & IFF_DEBUG)
  			printf ("%s%d: invalid cisco packet length: %d bytes\n",
  				ifp->if_name, ifp->if_unit, m->m_pkthdr.len);
--- 848,854 ----
  	struct ifaddr *ifa;
  	struct ifnet *ifp = &sp->pp_if;
  
! 	if (m->m_pkthdr.len < CISCO_PACKET_LEN) {
  		if (ifp->if_flags & IFF_DEBUG)
  			printf ("%s%d: invalid cisco packet length: %d bytes\n",
  				ifp->if_name, ifp->if_unit, m->m_pkthdr.len);


 With best regards.
---
Sandy
E-mail:  Internet: sandy@dream.demos.su    sandy@www.RoSprint.ru
            X.400: (C:USSR,A:SOVMAIL,O:SNUSSR,UN:A.KOVSHOV)
            X.400: (C:USA,A:TELEMAIL,O:SPRINTINTL,UN:A.KOVSHOV)