From owner-freebsd-current@freebsd.org Sat Jun 2 22:52:40 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3505CFF33C4; Sat, 2 Jun 2018 22:52:40 +0000 (UTC) (envelope-from gurenchan@gmail.com) Received: from mail-it0-x22a.google.com (mail-it0-x22a.google.com [IPv6:2607:f8b0:4001:c0b::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B4C147F187; Sat, 2 Jun 2018 22:52:39 +0000 (UTC) (envelope-from gurenchan@gmail.com) Received: by mail-it0-x22a.google.com with SMTP id 144-v6so5873753iti.5; Sat, 02 Jun 2018 15:52:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8HpuRO4JDSUxMm29QiRwBMkJKD4vfCpUdq2NHISlFAs=; b=BB8HnF10CBknWWv1XaWzIYY8iEpXZulKV2po7OWoY+bikQBxlolCxqAcZobcsSMkD+ se0T0i5z0nXuwEao9JSYLnmf4ooPlgJbkmHJPhWc8HhEpMZuuUOx6lqLb4ywMFT1JX1n woy2FvJD48jEjXkUteXtoEYIunP87SclB0Xz+HQ4VD/nUujOpy5MrYqY7G+UMp9mmsbj BXH/JHk/I8yprKfEQg9MjWBo9l+Dfq0wxaHl+CVr2jGIBn9WbaN4r14Z9epXLAbkIbeh GuWdWuhScdtZm4coFaXitvItsDk5fuy0J1nS01DHzrpmM2W8iFyU4zSWgxzuqB1+p2lP K74w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8HpuRO4JDSUxMm29QiRwBMkJKD4vfCpUdq2NHISlFAs=; b=d5FivDClM0XtnAbhkLhQHAoxtPBI3Top6lqEtr65FO3Ihcx6B38tk4G70OM+dATXFf DjP90m4C8t11ryM7+K5KFckgtPfkoMMbSCsD7SN/eiPH+HJi0kpItdb3FkU+pNcm4btc khKhzOc/70fkMuwdh/vw86LORCvMXhvwgRgvCxVSaThPVmcVULCdS4eSK+RtkuutfZEj J2bFYZEvo5lSoGl35awcIYnJLbVdsEsXV2JWkqy0Kpa1C5uFA1/T1zQGI6ly59v0pZ/V GnSXyM2exm4UfWTf/tjWFLPb5L+EIPRWu+RGErAzmH885qKJh66Swzx1u4smF+g9BbtO fK1A== X-Gm-Message-State: APt69E2OzKG7BqxrgFC4yI8H26oyrXWkO6S7DVAJVZOKBWpmWBJXQpcg WcIL0UqbMeOjSejCx3+pWGh6ni5+LvGpT/g3N0I= X-Google-Smtp-Source: ADUXVKLAZS1waKkkPvh8IwSFgVztmWaX4Ose7BGP5WYTBLbQuNs7h3eE+ax2wPMAUppVQJEdYyIiJ73lKJj7WU3Kbto= X-Received: by 2002:a24:918d:: with SMTP id i135-v6mr9419258ite.39.1527979959066; Sat, 02 Jun 2018 15:52:39 -0700 (PDT) MIME-Version: 1.0 References: <3ea085128a4e677a4d4150be18b366bd@kondratyev.su> <8f0bd4c0195ecaf1038268831576c461@kondratyev.su> In-Reply-To: <8f0bd4c0195ecaf1038268831576c461@kondratyev.su> From: blubee blubeeme Date: Sun, 3 Jun 2018 06:52:38 +0800 Message-ID: Subject: Re: Proper way to remove never used ioctls To: Vladimir Kondratyev Cc: Allan Jude , freebsd-current@freebsd.org, owner-freebsd-current@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jun 2018 22:52:40 -0000 On Sun, Jun 3, 2018, 02:34 Vladimir Kondratyev wrote: > On 2018-06-02 20:36, Allan Jude wrote: > > On 2018-06-02 11:03, Warner Losh wrote: > >> On Sat, Jun 2, 2018 at 7:33 AM, Vladimir Kondratyev > >> > >> wrote: > >> > >>> Hi, > >>> > >>> Our sys/mouse.h header has a definition of MOUSE_GETVARS and > >>> MOUSE_SETVARS > >>> ioctls which are not documented and only stubbed in a few drivers: > >>> mse(4), > >>> psm(4) and syscon's sysmouse(4). The only exception is MOUSE_GETVARS > >>> implemented in psm(4) > >>> > >>> Given the fact that they were introduced 20 years ago, implementation > >>> was > >>> never completed and googling on them shows no traces of usage in > >>> indexed > >>> universe, is it acceptable to just drop both defines and > >>> implementation > >>> w.o. leaving any COMPAT_FREEBSD shims? > >> > >> > >> I'd prepare a patch just removing them. I'd then send that patch to > >> the > >> ports mgr team and request a exp-run. Details for that can be found in > >> > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html > >> > >> Once that's done, submit a Phabricator review and send me email. I'll > >> make > >> sure it gets pushed in if there's no objections. > >> > >> Warner > > > > This indeed seems to be the correct approach. The exp-run will compile > > the entire ports tree against the patched base system, and identify any > > 3rd party software that fails to compile because of the change. > > Thank you, Allan and Warner! I'll follow yours advice. > > -- > WBR > Vladimir Kondratyev > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > This was great information. >