Date: Tue, 27 Apr 2021 13:38:41 +0200 From: "Kristof Provost" <kp@FreeBSD.org> To: "Alexander V. Chernikov" <melifaro@FreeBSD.org>, "Li-Wen Hsu" <lwhsu@freebsd.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 5d1403a79a3e - main - [rtsock] Enforce netmask/RTF_HOST consistency. Message-ID: <E9696582-EC46-4C3A-B339-F6421564161E@FreeBSD.org> In-Reply-To: <202104242303.13ON3w5l066307@gitrepo.freebsd.org> References: <202104242303.13ON3w5l066307@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25 Apr 2021, at 1:03, Alexander V. Chernikov wrote: > The branch main has been updated by melifaro: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3D5d1403a79a3e56403fb63c062252a= 23fce81e5f1 > > commit 5d1403a79a3e56403fb63c062252a23fce81e5f1 > Author: Alexander V. Chernikov <melifaro@FreeBSD.org> > AuthorDate: 2021-04-23 21:53:47 +0000 > Commit: Alexander V. Chernikov <melifaro@FreeBSD.org> > CommitDate: 2021-04-24 22:41:27 +0000 > > [rtsock] Enforce netmask/RTF_HOST consistency. > > Traditionally we had 2 sources of information whether the > added/delete route request targets network or a host route: > netmask (RTA_NETMASK) and RTF_HOST flag. > > The former one is tricky: netmask can be empty or can explicitly > specify the host netmask. Parsing netmask sockaddr requires = > per-family > parsing and that's what rtsock code traditionally avoided. As a = > result, > consistency was not enforced and it was possible to specify = > network with > the RTF_HOST flag and vice versa. > > Continue normalization efforts from D29826 and D29826 and ensure = > that > RTF_HOST flag always reflects host/network data from netmask = > field. > > Differential Revision: https://reviews.freebsd.org/D29958 > MFC after: 2 days I believe this commit triggers a number of regression test failures: = https://ci.freebsd.org/job/FreeBSD-main-amd64-test/18011/#showFailuresLin= k The easiest way to reproduce the problem is to `kldload ipsec ; cd = /usr/tests/sys/netipsec ; kyua test`. Reverting this patch allows the tests to pass again. (There are a few = others that also fail, but the ipsec tests appear to be the most = reliable way to demonstrate the problem.) Best regards, Kristof From owner-dev-commits-src-all@freebsd.org Tue Apr 27 12:42:13 2021 Return-Path: <owner-dev-commits-src-all@freebsd.org> Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5A0C25E7F59; Tue, 27 Apr 2021 12:42:13 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from forward500j.mail.yandex.net (forward500j.mail.yandex.net [IPv6:2a02:6b8:0:801:2::110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FV1cP0l91z3wNv; Tue, 27 Apr 2021 12:42:11 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from vla1-840b729f3759.qloud-c.yandex.net (vla1-840b729f3759.qloud-c.yandex.net [IPv6:2a02:6b8:c0d:4d18:0:640:840b:729f]) by forward500j.mail.yandex.net (Yandex) with ESMTP id 1E31B11C5E7D; Tue, 27 Apr 2021 15:26:55 +0300 (MSK) Received: from mail.yandex.ru (mail.yandex.ru [2a02:8084:d6bb:4a80:59f1:7c2c:a252:2fd0]) by vla1-840b729f3759.qloud-c.yandex.net (mxback/Yandex) with HTTP id rQagYZCIoiE1-QrIOTUO0; Tue, 27 Apr 2021 15:26:54 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfw.ru; s=mail; t=1619526414; bh=kPXpkFBYuJo3WIBi7cLtD5BTWuBuvdgI3eIul4YR7ME=; h=Message-Id:Cc:Subject:In-Reply-To:Date:References:To:From; b=ME+5kY+IG1VOUXDfMt6UajWUbODzyLnMxXbgDjZs4q/7xSbHvjOk24+wZrBGbWRhx 5Icvs1MOm0/8DYaeo+CFqOXHgHR1/XUTmCyag+Y5L3XR1G+i1utQHECIN9e+8lK+43 BYpxU6PA8Gpaq4JPLthBrsRfK/VD08u8ohVw5ugQ= Received: by vla1-3f9fbb467d83.qloud-c.yandex.net with HTTP; Tue, 27 Apr 2021 15:26:53 +0300 From: Alexander V. Chernikov <melifaro@freebsd.org> Envelope-From: melifaro@ipfw.ru To: Li-Wen Hsu <lwhsu@freebsd.org>, Kristof Provost <kp@freebsd.org> Cc: "src-committers@FreeBSD.org" <src-committers@freebsd.org>, "dev-commits-src-all@FreeBSD.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@FreeBSD.org" <dev-commits-src-main@freebsd.org> In-Reply-To: <E9696582-EC46-4C3A-B339-F6421564161E@FreeBSD.org> References: <E9696582-EC46-4C3A-B339-F6421564161E@FreeBSD.org> <202104242303.13ON3w5l066307@gitrepo.freebsd.org> Subject: Re: git: 5d1403a79a3e - main - [rtsock] Enforce netmask/RTF_HOST consistency. X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Tue, 27 Apr 2021 13:26:53 +0100 Message-Id: <11556361619526413@vla1-3f9fbb467d83.qloud-c.yandex.net> X-Rspamd-Queue-Id: 4FV1cP0l91z3wNv X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] MIME-Version: 1.0 Content-Type: text/plain X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/>; List-Post: <mailto:dev-commits-src-all@freebsd.org> List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Tue, 27 Apr 2021 12:42:13 -0000
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E9696582-EC46-4C3A-B339-F6421564161E>