From owner-svn-src-all@FreeBSD.ORG Tue Mar 15 21:01:15 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0C0BA106566B; Tue, 15 Mar 2011 21:01:15 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id D68568FC18; Tue, 15 Mar 2011 21:01:14 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 8348D46B90; Tue, 15 Mar 2011 17:01:14 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.10]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 616008A02A; Tue, 15 Mar 2011 17:01:13 -0400 (EDT) From: John Baldwin To: "Jung-uk Kim" Date: Tue, 15 Mar 2011 17:01:11 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.4-CBSD-20110107; KDE/4.4.5; amd64; ; ) References: <201103151947.p2FJlK3L057573@svn.freebsd.org> In-Reply-To: <201103151947.p2FJlK3L057573@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201103151701.11708.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 15 Mar 2011 17:01:14 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r219676 - head/sys/x86/x86 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2011 21:01:15 -0000 On Tuesday, March 15, 2011 3:47:20 pm Jung-uk Kim wrote: > Author: jkim > Date: Tue Mar 15 19:47:20 2011 > New Revision: 219676 > URL: http://svn.freebsd.org/changeset/base/219676 > > Log: > Do not let machdep.tsc_freq modify tsc_freq itself. It is bad for i386 as > it does not operate atomically. Actually, it serves no purpose. > > Noticed by: bde Ouch, please revert! We have depended on this for testing to workaround BIOS issues (e.g. the USB SMI# handler firing at a bad time during boot causing the TSC frequency to be calculated incorrectly). I agree it's a hack that this works, but it has actually proven useful in the past. -- John Baldwin