From owner-freebsd-current@freebsd.org Wed Jun 15 02:17:03 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 222ECB72F83 for ; Wed, 15 Jun 2016 02:17:03 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-211-154.reflexion.net [208.70.211.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C92DA2581 for ; Wed, 15 Jun 2016 02:17:02 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 24568 invoked from network); 15 Jun 2016 02:17:36 -0000 Received: from unknown (HELO rtc-sm-01.app.dca.reflexion.local) (10.81.150.1) by 0 (rfx-qmail) with SMTP; 15 Jun 2016 02:17:36 -0000 Received: by rtc-sm-01.app.dca.reflexion.local (Reflexion email security v7.90.3) with SMTP; Tue, 14 Jun 2016 22:17:06 -0400 (EDT) Received: (qmail 20922 invoked from network); 15 Jun 2016 02:17:06 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with SMTP; 15 Jun 2016 02:17:06 -0000 X-No-Relay: not in my network X-No-Relay: not in my network Received: from [192.168.0.105] (ip70-189-131-151.lv.lv.cox.net [70.189.131.151]) by iron2.pdx.net (Postfix) with ESMTPSA id 182F21C43E4; Tue, 14 Jun 2016 19:16:55 -0700 (PDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: mergemaster internally using make [for example] vs. WITH_META_MODE? From: Mark Millard In-Reply-To: <9fd734b0-2c17-214e-1dc6-a28d3d87cc05@FreeBSD.org> Date: Tue, 14 Jun 2016 19:16:59 -0700 Cc: FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: <04A4C0CC-20A6-4461-97C4-FB8D96C06FA3@dsl-only.net> References: <7C577F5B-545C-4D70-A78E-A19E35A24592@dsl-only.net> <36f0c42f-1ca0-f82c-da5b-74cb8f0240e4@FreeBSD.org> <533A2977-70C7-44A8-9768-840BAAC3F95F@dsl-only.net> <69eb8cb4-2d9b-7019-c9cb-52569090dd8b@FreeBSD.org> <9fd734b0-2c17-214e-1dc6-a28d3d87cc05@FreeBSD.org> To: Bryan Drewery X-Mailer: Apple Mail (2.3124) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2016 02:17:03 -0000 On 2016-Jun-14, at 6:48 PM, Bryan Drewery = wrote: > On 6/14/2016 5:13 PM, Mark Millard wrote: >>> The targets (at top-level) that META_MODE is applied to is a = whitelist >>> now after r301887. So it's safe to always pass it when building = from >>> the top-level. If it's an unsupported target it will internally = disable >>> META_MODE. >> So WITH_META_MODE=3Dyes is now always allowed. That still leaves the = questions of when WITH_META_MODE=3Dyes is necessary: For example, is it = ever required for the likes of mergemaster? (I'll use mergemaster to = illustrate a more general question that applies to other potential = scripts as well.) >=20 > There is no point to provide it to mergemaster or for it to use it > internally. The recommended way to use this feature is to add it to > /etc/src-env.conf and forget about it or specify it for > buildworld/buildkernel/universe (build) targets. There is also no = harm > in always defining it. That is the goal at least. >=20 > --=20 > Regards, > Bryan Drewery Okay. Thanks for the information. I asked in part because mergemaster [as an example] has code like: > # grep -i make /usr/sbin/mergemaster | more . . . > MM_MAKE=3D"make ${ARCHSTRING} -m ${SOURCEDIR}/share/mk" . . . > ${MM_MAKE} _obj SUBDIR_OVERRIDE=3Detc >/dev/null && . . . > ${MM_MAKE} everything SUBDIR_OVERRIDE=3Detc >/dev/null && . . . and "_obj" and "everything" overlap with the latest whitelist edit: > META_TGT_WHITELIST+=3D \ > _* build32 buildfiles buildincludes buildkernel buildsoft \ > buildworld everything kernel-toolchains kernels libraries \ > - native-xtools tinderbox toolchain toolchains universe worlds \ > - xdev xdev-build > + native-xtools showconfig tinderbox toolchain toolchains universe = \ > + worlds xdev xdev-build but in mergemaster are just specifically for SUBDIR_OVERRIDE=3Detc . =3D=3D=3D Mark Millard markmi at dsl-only.net