From owner-cvs-all Thu Oct 8 21:33:33 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA16725 for cvs-all-outgoing; Thu, 8 Oct 1998 21:33:33 -0700 (PDT) (envelope-from owner-cvs-all) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA16720; Thu, 8 Oct 1998 21:33:31 -0700 (PDT) (envelope-from jkh@time.cdrom.com) Received: from time.cdrom.com (jkh@localhost.cdrom.com [127.0.0.1]) by time.cdrom.com (8.8.8/8.8.8) with ESMTP id VAA04469; Thu, 8 Oct 1998 21:33:18 -0700 (PDT) (envelope-from jkh@time.cdrom.com) To: John Polstra cc: jkh@FreeBSD.ORG, committers@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libutil libutil.h In-reply-to: Your message of "Thu, 08 Oct 1998 21:11:19 PDT." <199810090411.VAA27179@austin.polstra.com> Date: Thu, 08 Oct 1998 21:33:18 -0700 Message-ID: <4466.907907598@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-all@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > > remove stdio.h include; I forgot Bruce's cardinal rule that header files > > shouldn't include other ones > > This broke make world: Fixed, sorry 'bout that. > This back-out seems counter-productive to me. You get the namespace > pollution no matter what. If you're using libutil.h then stdio.h > has to be included one way or another to avoid compilation errors. FWIW, I agree with you, but I don't have the energy to argue this with Bruce. :-) - Jordan