From owner-freebsd-current@FreeBSD.ORG Mon Mar 21 10:02:57 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0EDF6106566C; Mon, 21 Mar 2011 10:02:57 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 4F8058FC14; Mon, 21 Mar 2011 10:02:55 +0000 (UTC) Received: by fxm11 with SMTP id 11so6268945fxm.13 for ; Mon, 21 Mar 2011 03:02:55 -0700 (PDT) Received: by 10.223.1.73 with SMTP id 9mr4735357fae.44.1300701679287; Mon, 21 Mar 2011 03:01:19 -0700 (PDT) Received: from jessie.localnet (p5B2ED396.dip0.t-ipconnect.de [91.46.211.150]) by mx.google.com with ESMTPS id e23sm2391449faa.18.2011.03.21.03.01.17 (version=SSLv3 cipher=OTHER); Mon, 21 Mar 2011 03:01:18 -0700 (PDT) Sender: Bernhard Schmidt From: Bernhard Schmidt To: freebsd-current@freebsd.org Date: Mon, 21 Mar 2011 11:00:49 +0100 User-Agent: KMail/1.13.5 (Linux/2.6.32-29-generic; KDE/4.4.5; i686; ; ) References: <20110314162936.d3f8fd5b.ray@dlink.ua> <201103210704.23220.bschmidt@freebsd.org> <20110321112911.141e3548.ray@dlink.ua> In-Reply-To: <20110321112911.141e3548.ray@dlink.ua> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201103211100.49504.bschmidt@freebsd.org> Cc: Aleksandr Rybalko , Aleksandr Rybalko , "Sergey V. Dyatko" , Chadd , freebsd-mips@freebsd.org Subject: Re: [CFR]RT305xF support, w/o attachment X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: bschmidt@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2011 10:02:57 -0000 On Monday, March 21, 2011 10:29:11 Aleksandr Rybalko wrote: > Hi, > > On Mon, 21 Mar 2011 07:04:22 +0100 > Bernhard Schmidt wrote: > > >> On Monday 21 March 2011 00:16:01 Aleksandr Rybalko wrote: > >> > On Mon, 21 Mar 2011 05:59:45 +0800 > >> > Adrian Chadd wrote: > >> > > >> > > On 21 March 2011 04:28, Sergey V. Dyatko > >> > > wrote: > >> > > > >> > > > >> > > > Last patch from Aleksandr 'works fine for me', so... may be rt2860 > >> > > > should be replaced to 'rt' for example ? > >> > > > rt0: flags= blah-blah-blah IHMO looks more .....nice(?) than > >> > > > rt28600: flags= > >> > > > > >> > > > >> > > Yup, that's a good idea. Aleksandr, can you please do that? > >> > > >> > Off-course I can, but seems better name will be rtw or rtn, because we > >> > already have if_rt (for RT3052 ether) which have iface name "rt". > >> > > >> > I think "rtn" is best. > >> > > >> > Maybe someone have better? > >> > >> rtw is a name for a Realtek driver. > Realtek driver called urtw, but I agree with you to avoid confusion. That rtw driver I'm speaking of is for older Realtek 8180/8185 PCI based chips. Granted, not in our tree, but it exists. urtw(4) is for 8187B/L USB chipsets. > >> > >> I'd prefer if can keep this driver in sync with the OpenBSD one where > >> it is clearly derived from. So, rt28xx and rt30xx support has to be an > >> extension to ral(4). That shouldn't be to hard to do, just throw in the > >> code into dev/ral/ and hook it to the pci/ops code. > This driver closer to USB run(4), but this use USB and difference still big. > > In future, not so closer, I will try to join run, ral and my rt2860. But there is too much work and I need to find time for it. Please don't. There is a reason the PCI and USB chipsets, even if derived from the same base chipset, have different drivers. The BUS specific implementation/restrictions are way too different/important. Trying to merge those will only make your head ache :) > > >> > > So for now, best name is "rtn". > > If no objections, I send updated patch with new name. I still don't think this is the way to go. Adding a totally independent driver now and replacing (or merging) it later simple won't work. Also, it is quite annoying from user point of view. I urge you to have a closer look at ral(4) and it's way of handling RT2500 and RT2600 specific differences. In it's simplest form you can copy the OpenBSD code 1:1 without any functional changes, heck, it's the source of this driver anyway. -- Bernhard