From owner-freebsd-current@FreeBSD.ORG Tue Jan 27 17:35:29 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 61E7B16A4CE for ; Tue, 27 Jan 2004 17:35:29 -0800 (PST) Received: from amelia.vangyzen.net (rdu88-246-220.nc.rr.com [24.88.246.220]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6814C43D54 for ; Tue, 27 Jan 2004 17:35:28 -0800 (PST) (envelope-from vangyzen@stat.duke.edu) Received: from localhost (localhost [127.0.0.1]) by amelia.vangyzen.net (Postfix) with ESMTP id 75479FD0FB for ; Tue, 27 Jan 2004 20:35:27 -0500 (EST) From: Eric van Gyzen Organization: ISDS, Duke University To: freebsd-current@freebsd.org Date: Tue, 27 Jan 2004 20:19:06 -0500 User-Agent: KMail/1.5.4 MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200401272017.31161.vangyzen@stat.duke.edu> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject: libexec/ftpd/ftpd.c and pam X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2004 01:35:29 -0000 The auth_pam function in src/libexec/ftpd/ftpd.c defines a local variable pam_handle_t *pamh = NULL; which shadows the same variable in the global scope. This seems unintentional, because the global pamh is never initialized by pam_start(), so the other functions in ftpd.c always operate on a NULL pam_handle_t. Feel free to correct me if I'm speaking from the wrong end of my body. Eric -- Eric van Gyzen Sr. Systems Programmer http://www.stat.duke.edu/~vangyzen/ ISDS, Duke University