From owner-freebsd-emulation@FreeBSD.ORG Mon Aug 7 21:19:23 2006 Return-Path: X-Original-To: freebsd-emulation@freebsd.org Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC27316A4DF for ; Mon, 7 Aug 2006 21:19:23 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1BA4C43D6B for ; Mon, 7 Aug 2006 21:19:12 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from Andro-Beta.Leidinger.net (p54A5F08A.dip.t-dialin.net [84.165.240.138]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.6/8.13.6) with ESMTP id k77L4Tnj071035; Mon, 7 Aug 2006 23:04:30 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) by Andro-Beta.Leidinger.net (8.13.4/8.13.3) with ESMTP id k77LJ8e1070990; Mon, 7 Aug 2006 23:19:09 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Date: Mon, 7 Aug 2006 23:20:55 +0200 From: Alexander Leidinger To: "Intron" Message-ID: <20060807232055.77a70f8a@Magellan.Leidinger.net> In-Reply-To: References: <1153994127.11460@origin.intron.ac> <20060728093647.GA32168@stud.fit.vutbr.cz> X-Mailer: Sylpheed-Claws 2.4.0 (GTK+ 2.8.20; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new Cc: alexander@Leidinger.net, freebsd-emulation@freebsd.org Subject: Re: [Updated on 2006-07-29] Re: My Linux AIO Implementation Calling for Test X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Aug 2006 21:19:23 -0000 Quoting "Intron" (Sat, 29 Jul 2006 18:05:47 +0800): > Download: http://ftp.intron.ac/tmp/linux_aio-20060729.tar.bz2 > > 1. Use LMSG(). > 2. I wonder whether ARGS() is handy enough. Instead, the keyword __func__ > instituted by ISO C99 should be used. See my DARGPRINTF(). > 3. Some modifications for style(9). There are some style problems: - macros do not have to end with a ';' - lines with more than 80 characters (so far they can be changed to continue on the next line or some similar modifications) - between switch/if/while/... and the '(' should be a space - code which isn't used should be disabled with preprocessor directives, not with comments - '}' and '{' should be on the same line as the "else" - maybe more... And some code problems: - "Both User Space and Kernel Memory Leaked!" doesn't look very encouraging, what's the reason for this? How often can this occour and when? - please use the l_int, l_uint, ... types instead of plain int, unsigned, ... so that it can be used on amd64 too (the linuxolator runs in "32bit mode" there, so a 64bit long will break there) Maybe I will find some more stuff later... Bye, Alexander. -- The wages of sin is death, but so is the salary of virtue, and at least the evil get to go home early on Fridays. (Witches Abroad) http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137