Date: Wed, 3 Jun 2015 23:01:00 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Luiz Otavio O Souza <loos@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r283948 - head/sys/dev/dwc Message-ID: <20150603200100.GB73119@FreeBSD.org> In-Reply-To: <201506031448.t53Em4Gn090709@svn.freebsd.org> References: <201506031448.t53Em4Gn090709@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 03, 2015 at 02:48:04PM +0000, Luiz Otavio O Souza wrote: L> Author: loos L> Date: Wed Jun 3 14:48:03 2015 L> New Revision: 283948 L> URL: https://svnweb.freebsd.org/changeset/base/283948 L> L> Log: L> Fix the OACTIVE handling on if_dwc. L> L> Previously the OACTIVE flag was being set when the tx descriptors are fully L> allocated but it wasn't unset anywhere. L> L> As soon as a packet is transmitted, unset the OACTIVE flag and call start L> routine to push any pending packets from the tx queue. L> L> This closes another race where a full tx queue would jam the tx path (tx L> queue is full, new packets cannot be added to queue and dwc_txstart never L> gets called). The only real fix of OACTIVE handling is removing OACTIVE :) -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150603200100.GB73119>