From owner-freebsd-bugs@FreeBSD.ORG  Wed Apr 14 13:50:16 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2E79C16A4CF
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 14 Apr 2004 13:50:16 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0F80843D55
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 14 Apr 2004 13:50:16 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i3EKoFbv025052	for <freebsd-bugs@freefall.freebsd.org>;
	Wed, 14 Apr 2004 13:50:15 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i3EKoFH4025051;
	Wed, 14 Apr 2004 13:50:15 -0700 (PDT)
	(envelope-from gnats)
Resent-Date: Wed, 14 Apr 2004 13:50:15 -0700 (PDT)
Resent-Message-Id: <200404142050.i3EKoFH4025051@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Stephan Uphoff <ups@tree.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9283416A4CE
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 14 Apr 2004 13:48:49 -0700 (PDT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8E8B443D48
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 14 Apr 2004 13:48:49 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.10/8.12.10) with ESMTP id i3EKmn72026457
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 14 Apr 2004 13:48:49 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.10/8.12.10/Submit) id i3EKmmJg026456;
	Wed, 14 Apr 2004 13:48:49 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200404142048.i3EKmmJg026456@www.freebsd.org>
Date: Wed, 14 Apr 2004 13:48:49 -0700 (PDT)
From: Stephan Uphoff <ups@tree.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Subject: kern/65548: misplaced bracket in m_getcl (subr_mbuf.c)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2004 20:50:16 -0000


>Number:         65548
>Category:       kern
>Synopsis:       misplaced bracket in m_getcl (subr_mbuf.c)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 14 13:50:15 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Stephan Uphoff
>Release:        current
>Organization:
>Environment:
N/A
>Description:
misplaced bracket in m_getcl

	if (mb->m_ext.ext_buf == NULL) {
		(void)m_free(mb);
		mb = NULL;
	} else {
		_mcl_setup(mb);
		_mext_init_ref(mb, &cl_refcntmap[cl2ref(mb->m_ext.ext_buf)]);
	}
#ifdef MAC
	if (flags & M_PKTHDR) {
		if (mac_init_mbuf(mb, MBTOM(how)) != 0) {
			m_free(mb);
			return (NULL);
		}
	}
#endif


should be


	if (mb->m_ext.ext_buf == NULL) {
		(void)m_free(mb);
		mb = NULL;
	} else {
		_mcl_setup(mb);
		_mext_init_ref(mb, &cl_refcntmap[cl2ref(mb->m_ext.ext_buf)]);
	
#ifdef MAC
		if (flags & M_PKTHDR) {
			if (mac_init_mbuf(mb, MBTOM(how)) != 0) {
				m_free(mb);
				return (NULL);
			}
		}
#endif
       }
>How-To-Repeat:
      
>Fix:
      
>Release-Note:
>Audit-Trail:
>Unformatted: