From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Apr 24 09:50:17 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DCA0C16A404 for ; Mon, 24 Apr 2006 09:50:16 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3BAD343D48 for ; Mon, 24 Apr 2006 09:50:16 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k3O9oGql030318 for ; Mon, 24 Apr 2006 09:50:16 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k3O9oFOm030317; Mon, 24 Apr 2006 09:50:15 GMT (envelope-from gnats) Resent-Date: Mon, 24 Apr 2006 09:50:15 GMT Resent-Message-Id: <200604240950.k3O9oFOm030317@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitry Morozovsky Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF9BF16A402 for ; Mon, 24 Apr 2006 09:41:57 +0000 (UTC) (envelope-from marck@woozle.rinet.ru) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4805943D6B for ; Mon, 24 Apr 2006 09:41:52 +0000 (GMT) (envelope-from marck@woozle.rinet.ru) Received: from woozle.rinet.ru (localhost [127.0.0.1]) by woozle.rinet.ru (8.13.6/8.13.4) with ESMTP id k3O9fpfV027569 for ; Mon, 24 Apr 2006 13:41:51 +0400 (MSD) (envelope-from marck@woozle.rinet.ru) Received: (from marck@localhost) by woozle.rinet.ru (8.13.6/8.13.4/Submit) id k3O9fpOa027568; Mon, 24 Apr 2006 13:41:51 +0400 (MSD) (envelope-from marck) Message-Id: <200604240941.k3O9fpOa027568@woozle.rinet.ru> Date: Mon, 24 Apr 2006 13:41:51 +0400 (MSD) From: Dmitry Morozovsky To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/96252: [patch] sysutils/cpdup can not handle snapshot files X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dmitry Morozovsky List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Apr 2006 09:50:17 -0000 >Number: 96252 >Category: ports >Synopsis: [patch] sysutils/cpdup can not handle snapshot files >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Apr 24 09:50:15 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Dmitry Morozovsky >Release: FreeBSD 6-STABLE i386 >Organization: Cronyx Plus LLC (RiNet ISP) >Environment: System: FreeBSD 6-STABLE >Description: sysutils/cpdup, while being great utility for file systems copy, can not properly handle files with holes, hence is never able to copy snapshot files (wee, on a comparable file systems). The following patch sould fix this by simply skipping inodes with snapshot flag set. >How-To-Repeat: >Fix: #/bin/sh echo c - files mkdir -p files > /dev/null 2>&1 echo x - files/patch-cpdup.c sed 's/^X//' >files/patch-cpdup.c << 'END-of-files/patch-cpdup.c' X X$FreeBSD$ X X--- cpdup.c.orig X+++ cpdup.c X@@ -321,6 +321,11 @@ X X if (lstat(spath, &st1) != 0) X return(0); X+#ifdef SF_SNAPSHOT X+ /* skip snapshot files: we cannot handle files larger than file system */ X+ if (st1.st_flags & SF_SNAPSHOT) X+ return(0); X+#endif X st2.st_mode = 0; /* in case lstat fails */ X st2.st_flags = 0; /* in case lstat fails */ X if (dpath && lstat(dpath, &st2) == 0) END-of-files/patch-cpdup.c patch << 'END-of-Makefile-Patch' Index: Makefile =================================================================== RCS file: /home/ncvs/ports/sysutils/cpdup/Makefile,v retrieving revision 1.11 diff -u -u -r1.11 Makefile --- Makefile 11 Dec 2004 17:49:48 -0000 1.11 +++ Makefile 24 Apr 2006 09:26:34 -0000 @@ -7,6 +7,7 @@ PORTNAME= cpdup PORTVERSION= 1.05 +PORTREVISION= 1 CATEGORIES= sysutils MASTER_SITES= http://apollo.backplane.com/FreeBSDPorts/ #MASTER_SITE_SUBDIR= cp END-of-Makefile-Patch exit >Release-Note: >Audit-Trail: >Unformatted: