From owner-svn-src-all@freebsd.org Tue Sep 3 14:07:22 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 758D8DCCF8; Tue, 3 Sep 2019 14:06:38 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7zd6b7Hz4PlP; Tue, 3 Sep 2019 14:06:37 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 56F761A961; Tue, 3 Sep 2019 14:06:13 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 5BE4E13741; Wed, 10 Apr 2019 18:02:16 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 21536838E6; Wed, 10 Apr 2019 18:02:16 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 0E0A113740; Wed, 10 Apr 2019 18:02:16 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id CA9D21373A; Wed, 10 Apr 2019 18:02:12 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 79BD0838D1; Wed, 10 Apr 2019 18:02:12 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x52e.google.com with SMTP id y3so1991461pgk.12; Wed, 10 Apr 2019 11:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=LOcvp28Qn6g0Nrsg/mUOyBeHFwWVUiw9OxHNLzy2xH0=; b=Zd6+fCiEyYv77Do99sDXPqQMnuR/pOK1ipKDvy2ccnmDkrONHZmrEAsjLGfYSmqhQm Bj6ulj1CIjRCm9MupIgYq8zYuujTDH02p5pA51ARHIUtXqmBvxhfFiXpkSFq//Fqb84f vWvFgHIB9BjBg747ywvTZKtADWS72SvI3UsnXv5dIpClEehg2o7f0icBbuZbHFbLkCc0 MIUdKrfNC7w2jRwLRY27wjNJlAOJa6QSXKsTDkVIbTC/Bg4BRB1dPQUTNkizoBlCoyzb xQHRNYotHIGpDjXMA8n84Eo7vMox++bTXzpzrFdrUiLUIQiUKW3EL3fzrJwXlSIjOmcW WgQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=LOcvp28Qn6g0Nrsg/mUOyBeHFwWVUiw9OxHNLzy2xH0=; b=OK5CAFiUw8gIV5o6kQUGkCV6zy4st9w/v/BE/rLIGAm3EKxxqH9lZORmN8+5c7mtpR ddvhfmhXTQ58MnSB95TIGb6BvJty+Nu7wDbTO9IJ8ggWaWDu3gFQ0c8aMQrAObh8HWjn Tvr+DBHr9jDSCqlE9yWRBpFC4MKTtRB0KLLHABWefK3rQV3krWYTRA2ywCVJlBwnbHpv wAUPASt0gaE1UiACKtqFKSSUe4ekVZMEXrDt4aJJ3/SfRf/+wq/cL0ggbX7Octj7kX2G ALscwh67AWP7bjWQS499eayUf+OIKtJ7HyB5QQON2O/H42nAMbNS6Nhy64C9CowxwwtC wPaQ== X-Gm-Message-State: APjAAAXl/NjexvKO0m/OXpzmVrtF82FgZkrJ14CDZ46lAQcxcSGFxXpv k6i0Ywthxdy29YJJUk9eu9U= X-Google-Smtp-Source: APXvYqwL/aRdpTMOkm0R/ue8mcZNdYhUKvYyDnPSPW/mI4Gn5XZWBA4fkZmIWg3EkHFS0A4ER9EBAg== X-Received: by 2002:a62:4351:: with SMTP id q78mr45850173pfa.86.1554919330280; Wed, 10 Apr 2019 11:02:10 -0700 (PDT) Received: from ?IPv6:2607:fb90:822a:6269:7883:c4a8:e284:632e? ([2607:fb90:822a:6269:7883:c4a8:e284:632e]) by smtp.gmail.com with ESMTPSA id s5sm41665005pgv.8.2019.04.10.11.02.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Apr 2019 11:02:09 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r346081 - head/cddl/usr.sbin/zfsd From: Enji Cooper X-Mailer: iPhone Mail (16E227) In-Reply-To: <20190410155509.GU1923@kib.kiev.ua> Cc: Edward Tomasz Napierala , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <4BDE4771-EA33-4746-851E-674EF31D0174@gmail.com> References: <201904101342.x3ADgbXM033389@repo.freebsd.org> <20190410155509.GU1923@kib.kiev.ua> To: Konstantin Belousov Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 21536838E6 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.986,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:07:22 -0000 X-Original-Date: Wed, 10 Apr 2019 11:02:08 -0700 X-List-Received-Date: Tue, 03 Sep 2019 14:07:22 -0000 > On Apr 10, 2019, at 08:55, Konstantin Belousov wrote= : >=20 >> On Wed, Apr 10, 2019 at 01:42:37PM +0000, Edward Tomasz Napierala wrote: >> Author: trasz >> Date: Wed Apr 10 13:42:37 2019 >> New Revision: 346081 >> URL: https://svnweb.freebsd.org/changeset/base/346081 >>=20 >> Log: >> Make zfsd(8) build obey CFLAGS. >>=20 >> Reviewed by: imp >> Obtained from: CheriBSD >> MFC after: 2 weeks >> Sponsored by: DARPA, AFRL >> Differential Revision: https://reviews.freebsd.org/D19865 >>=20 >> Modified: >> head/cddl/usr.sbin/zfsd/Makefile.common >>=20 >> Modified: head/cddl/usr.sbin/zfsd/Makefile.common >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D >> --- head/cddl/usr.sbin/zfsd/Makefile.common Wed Apr 10 13:41:34 2019 = (r346080) >> +++ head/cddl/usr.sbin/zfsd/Makefile.common Wed Apr 10 13:42:37 2019 = (r346081) >> @@ -30,7 +30,7 @@ INCFLAGS+=3D -I${SRCTOP}/sys/cddl/contrib/opensolaris/u= t >> INCFLAGS+=3D -I${SRCTOP}/sys/cddl/contrib/opensolaris/uts/common/fs/zfs >> INCFLAGS+=3D -I${SRCTOP}/cddl/usr.sbin >>=20 >> -CFLAGS=3D -g -DNEED_SOLARIS_BOOLEAN ${INCFLAGS} >> +CFLAGS+=3D -g -DNEED_SOLARIS_BOOLEAN ${INCFLAGS} > Why the flags unconditionally set -g ? It shouldn=E2=80=99t be explicitly set. That=E2=80=99s what DEBUG_FLAGS is f= or. -Enji=