From owner-svn-src-all@FreeBSD.ORG  Tue Nov 13 07:01:32 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 9F9D9727;
 Tue, 13 Nov 2012 07:01:32 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net
 [IPv6:2001:7b8:2ff:146::2])
 by mx1.freebsd.org (Postfix) with ESMTP id 590278FC08;
 Tue, 13 Nov 2012 07:01:32 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7:0:7d1a:da9d:a8b2:d0aa] (unknown
 [IPv6:2001:7b8:3a7:0:7d1a:da9d:a8b2:d0aa])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id CF5295C59;
 Tue, 13 Nov 2012 08:01:30 +0100 (CET)
Message-ID: <50A1F049.3070800@FreeBSD.org>
Date: Tue, 13 Nov 2012 08:01:29 +0100
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Ben Kaduk <minimarmot@gmail.com>
Subject: Re: svn commit: r242934 - head/sys/dev/xen/netback
References: <201211122228.qACMSWbs020517@svn.freebsd.org>
 <CAK2BMK5c8wb9dSostjsjUHZOXGUG1KiWE1xHQi5sHtJMRMaSEQ@mail.gmail.com>
In-Reply-To: <CAK2BMK5c8wb9dSostjsjUHZOXGUG1KiWE1xHQi5sHtJMRMaSEQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Nov 2012 07:01:32 -0000

On 2012-11-12 23:57, Ben Kaduk wrote:> On Mon, Nov 12, 2012 at 5:28 PM, Dimitry Andric <dim@freebsd.org> wrote:
>> Author: dim
>> Date: Mon Nov 12 22:28:32 2012
>> New Revision: 242934
>> URL: http://svnweb.freebsd.org/changeset/base/242934
>>
>> Log:
>>    Redo r242889, now using the method from projects/amd64_xen_pv r240747.
>>
>>    Reminded by:  kib
>>    MFC after:    3 days
>>
>> Modified:
>>    head/sys/dev/xen/netback/netback_unit_tests.c
>>
>> Modified: head/sys/dev/xen/netback/netback_unit_tests.c
>> ==============================================================================
>> --- head/sys/dev/xen/netback/netback_unit_tests.c       Mon Nov 12 22:01:29 2012        (r242933)
>> +++ head/sys/dev/xen/netback/netback_unit_tests.c       Mon Nov 12 22:28:32 2012        (r242934)
>> @@ -58,11 +58,11 @@ __FBSDID("$FreeBSD$");
>>   #define        TOSTRING(x) STRINGIFY(x)
>>
>>   /**
>> - * Writes an error message to buffer if cond is false, and returns true
>> - * iff the assertion failed.  Note the implied parameters buffer and
>> + * Writes an error message to buffer if cond is false
>> + * Note the implied parameters buffer and
>
> At risk of being Bruce, aren't comments like this supposed to be
> complete sentences and end with a full stop?

Yes, but I purposely copied what was in the projects/amd64_xen_pv
branch, to make it easier for those people to merge back.  Please take
up comment comments with them, thanks. ;-)