From owner-cvs-ports@FreeBSD.ORG Sun Jul 31 08:48:04 2011 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 7CA031065670; Sun, 31 Jul 2011 08:48:04 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 65-241-43-4.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 0E07614DAA2; Sun, 31 Jul 2011 08:48:04 +0000 (UTC) Message-ID: <4E3516C3.9070605@FreeBSD.org> Date: Sun, 31 Jul 2011 01:48:03 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:5.0) Gecko/20110723 Thunderbird/5.0 MIME-Version: 1.0 To: C++ RTMP Server Support References: <201107301549.p6UFn7rK070976@repoman.freebsd.org> <4E3495B0.3070405@FreeBSD.org> <4E35108D.1040907@FreeBSD.org> <4E3510F7.2000405@FreeBSD.org> <7C192122-697C-49BB-AADB-446C24962000@rtmpd.com> In-Reply-To: <7C192122-697C-49BB-AADB-446C24962000@rtmpd.com> X-Enigmail-Version: 1.2pre OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Jin-Sih Lin , cvs-ports@FreeBSD.org, Li-Wen Hsu , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/crtmpserver Makefile distinfo pkg-plist ports/net/crtmpserver/files crtmpserver.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2011 08:48:04 -0000 On 07/31/2011 01:34, C++ RTMP Server Support wrote: > Oh, I see the difference now. You basically use another construct to > gather the (default) values. IMHO, my solution is much much clear > because all variables which are read from rc.conf are in one single > place and for beginners like me the script is easier to read. > > Besides, you remove one variable (crtmpserver_config) and you put > it's default value inside the required_files variable, but you add > another one called pidfile. > > Again, IMHO, my version is easier to read. You still don't understand. pidfile= is a requirement. As I said in my first message, it's special to rc.subr. This needs to be fixed. As for how pidfile= and required_files= are set, that's a style issue that I'm less concerned about. What you are saying is that this is easier to read: : ${name_config:=foo} : ${name_pidfile:=bar} required_files=$name_config pidfile=$name_pidfile What I'm saying is that doing it that way means that you're working harder than you have to. The way I had it in the patch means that each variable only has to be handled once. It may be slightly more difficult to read for novices, but it's not _that_ complex; and reduces the chances that a mistake will be made. However, if you choose not to use the style that I suggested, I'm not too concerned about that. However, the pidfile issue has to be fixed. Doug -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/