From owner-svn-src-all@freebsd.org  Tue May 29 19:39:14 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71C2FF7062A;
 Tue, 29 May 2018 19:39:14 +0000 (UTC)
 (envelope-from eric@vangyzen.net)
Received: from smtp.vangyzen.net (hotblack.vangyzen.net [199.48.133.146])
 by mx1.freebsd.org (Postfix) with ESMTP id 1F1FC7B50A;
 Tue, 29 May 2018 19:39:13 +0000 (UTC)
 (envelope-from eric@vangyzen.net)
Received: from sweettea.beer.town (unknown [76.164.8.130])
 by smtp.vangyzen.net (Postfix) with ESMTPSA id 3545F5646B;
 Tue, 29 May 2018 14:39:12 -0500 (CDT)
Subject: Re: svn commit: r334347 - head/lib/libpmc
To: Matt Macy <mmacy@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201805291907.w4TJ70L9004416@repo.freebsd.org>
From: Eric van Gyzen <eric@vangyzen.net>
Openpgp: preference=signencrypt
Message-ID: <57a10ac9-f190-3bb7-0fec-8d43a8827455@vangyzen.net>
Date: Tue, 29 May 2018 14:39:08 -0500
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <201805291907.w4TJ70L9004416@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 May 2018 19:39:14 -0000

On 05/29/2018 14:07, Matt Macy wrote:
>  	if (pmc_pmu_pmcallocate(ctrname, &pmc_config) == 0) {
> -		if (PMC_CALL(PMCALLOCATE, &pmc_config) < 0)
> -			return (errno);
> -		free(spec_copy);
> +		if (PMC_CALL(PMCALLOCATE, &pmc_config) < 0) {
> +			retval = errno;
> +			goto out;
> +		}
>  		*pmcid = pmc_config.pm_pmcid;
> -		return (0);
> +		goto out;

This now returns -1 on the successful path.

Feel free to start throwing things at me now.  ;)

Eric