From owner-svn-ports-all@freebsd.org  Mon Aug 31 10:49:13 2015
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65AF59C650C;
 Mon, 31 Aug 2015 10:49:13 +0000 (UTC)
 (envelope-from freebsd.contact@marino.st)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 407971DBC;
 Mon, 31 Aug 2015 10:49:12 +0000 (UTC)
 (envelope-from freebsd.contact@marino.st)
Received: from [192.168.0.23] (unknown [130.255.19.36])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id D87A743BB7;
 Mon, 31 Aug 2015 05:48:59 -0500 (CDT)
Subject: Re: svn commit: r395661 - head/graphics/graphite2
To: Raphael Kubo da Costa <rakuco@FreeBSD.org>, ports-committers@freebsd.org, 
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
References: <201508311018.t7VAIp8v001403@repo.freebsd.org>
Reply-To: marino@freebsd.org
From: John Marino <freebsd.contact@marino.st>
Message-ID: <55E4310F.8090809@marino.st>
Date: Mon, 31 Aug 2015 12:48:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.0.1
MIME-Version: 1.0
In-Reply-To: <201508311018.t7VAIp8v001403@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Aug 2015 10:49:13 -0000

On 8/31/2015 12:18 PM, Raphael Kubo da Costa wrote:
> Author: rakuco
> Date: Mon Aug 31 10:18:50 2015
> New Revision: 395661
> URL: https://svnweb.freebsd.org/changeset/ports/395661
> 
> Log:
>   Drop USES=iconv.
>   
>   The port does not actually use iconv anywhere, so drop the dependency. While
>   here, also stop setting LDFLAGS since it is not necessary (as verified by
>   building on 9.3, 10.1 and HEAD).
>   

I just want to point out that it's possible LDFLAGS=-L${LOCALBASE}/lib
is still needed depending on the compiler.  Some compilers may look
there by default (thus LDFLAG not needed) but others may not.  I'm not
saying this commit is wrong, only that the justification "it builds on
standard runs" can be dangerous thinking.

LDFLAGS should be set if "-L" is not explicitly set, in general.
Usually one of the USES tools will bring it in though.

John