From owner-freebsd-current  Thu Aug 16  7:59: 6 2001
Delivered-To: freebsd-current@freebsd.org
Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206])
	by hub.freebsd.org (Postfix) with ESMTP id 942A537B408
	for <current@freebsd.org>; Thu, 16 Aug 2001 07:59:00 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 82032 invoked from network); 16 Aug 2001 14:59:00 -0000
Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender <jhb@FreeBSD.org>)
          by mail6.speakeasy.net (qmail-ldap-1.03) with SMTP
          for <obrien@freebsd.org>; 16 Aug 2001 14:59:00 -0000
Message-ID: <XFMail.010816075904.jhb@FreeBSD.org>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20010815193517.A8445@dragon.nuxi.com>
Date: Thu, 16 Aug 2001 07:59:04 -0700 (PDT)
From: John Baldwin <jhb@FreeBSD.org>
To: "David O'Brien" <obrien@freebsd.org>
Subject: RE: mutex Giant not owned
Cc: current@freebsd.org
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG


On 16-Aug-01 David O'Brien wrote:
># uname -a
> FreeBSD phuong.nuxi.com 5.0-CURRENT FreeBSD 5.0-CURRENT #12: Sun Jul 15
> 19:07:45 PDT 2001    
> rootk@phuong.nuxi.com:/files/Current/sys/alpha/compile/DS20  alpha

Looks like a trapsignal() in trap() is being called w/o Giant.  I'll look at it.

Try this:

Index: trap.c
===================================================================
RCS file: /usr/cvs/src/sys/alpha/alpha/trap.c,v
retrieving revision 1.73
diff -u -r1.73 trap.c
--- trap.c      2001/08/10 22:53:25     1.73
+++ trap.c      2001/08/16 04:29:40
@@ -611,14 +611,15 @@
        framep->tf_regs[FRAME_TRAPARG_A0] = a0;
        framep->tf_regs[FRAME_TRAPARG_A1] = a1;
        framep->tf_regs[FRAME_TRAPARG_A2] = a2;
+       mtx_lock(&Giant);
        trapsignal(p, i, ucode);
 out:
        if (user) {
                framep->tf_regs[FRAME_SP] = alpha_pal_rdusp();
                userret(p, framep, sticks);
-               if (mtx_owned(&Giant))
-                       mtx_unlock(&Giant);
        }
+       if (mtx_owned(&Giant))
+               mtx_unlock(&Giant);
        return;
 
 dopanic:

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message