From owner-p4-projects@FreeBSD.ORG Wed Sep 21 18:16:15 2005 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 347DC16A424; Wed, 21 Sep 2005 18:16:15 +0000 (GMT) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0724A16A421 for ; Wed, 21 Sep 2005 18:16:15 +0000 (GMT) (envelope-from soc-chenk@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0102243D5A for ; Wed, 21 Sep 2005 18:16:12 +0000 (GMT) (envelope-from soc-chenk@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8LIGCFj000606 for ; Wed, 21 Sep 2005 18:16:12 GMT (envelope-from soc-chenk@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8LIGC7D000603 for perforce@freebsd.org; Wed, 21 Sep 2005 18:16:12 GMT (envelope-from soc-chenk@freebsd.org) Date: Wed, 21 Sep 2005 18:16:12 GMT Message-Id: <200509211816.j8LIGC7D000603@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to soc-chenk@freebsd.org using -f From: soc-chenk To: Perforce Change Reviews Cc: Subject: PERFORCE change 84065 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2005 18:16:16 -0000 http://perforce.freebsd.org/chv.cgi?CH=84065 Change 84065 by soc-chenk@soc-chenk_leavemealone on 2005/09/21 18:15:20 fix the bogus LOR fix Submitted by: soc-chenk Affected files ... .. //depot/projects/soc2005/fuse4bsd2/Changelog#11 edit .. //depot/projects/soc2005/fuse4bsd2/README.html#6 edit .. //depot/projects/soc2005/fuse4bsd2/fuse_module/fuse.c#9 edit Differences ... ==== //depot/projects/soc2005/fuse4bsd2/Changelog#11 (text+ko) ==== @@ -1,3 +1,9 @@ +Wed Sep 21 20:05:27 CEST 2005 at node: creo.hu, nick: csaba + tagged 0.2.11 + +Wed Sep 21 20:04:50 CEST 2005 at node: creo.hu, nick: csaba + * fix the bogus LOR fix + Wed Sep 21 11:58:29 CEST 2005 at node: creo.hu, nick: csaba tagged 0.2.1 ==== //depot/projects/soc2005/fuse4bsd2/README.html#6 (text+ko) ==== @@ -55,7 +55,7 @@

  • - The FreeBSD module. Source tarballs are provided at [WWW]http://creo.hu/~csaba/projects/fuse4bsd/downloads/ under the name fuse4bsd-<version>.tar.* (latest release is 0.2.1, date of release: 21th Sep 2005). The current code is available via Darcs, you can fetch it by + The FreeBSD module. Source tarballs are provided at [WWW]http://creo.hu/~csaba/projects/fuse4bsd/downloads/ under the name fuse4bsd-<version>.tar.* (latest release is 0.2.11, date of release: 21th Sep 2005). The current code is available via Darcs, you can fetch it by 

     darcs get http://creo.hu/~csaba/darcs-repos/fuse4bsd
    command, or via [WWW]Perforce (you can use this latter link for online source code browsing).

    • ==== //depot/projects/soc2005/fuse4bsd2/fuse_module/fuse.c#9 (text+ko) ==== @@ -4569,13 +4569,21 @@ */ fvdat = vp->v_data; + /* + * It seemed to be a good idea to lock the filehandle lock only before + * doing iterate_filehandle but that configuration is suspected to cause + * LOR alerts, so now we get the filehandle lock before the fuse_data + * lock. + */ sx_slock(&fvdat->fh_lock); if ((err = fdisp_get_vopdata(&fdi, vp->v_mount))) - return (err); + goto out; iterate_filehandles(vp, td, NULL, 0, fuse_fsync_filehandle, &fdi); sx_sunlock(fdi.slock); + +out: sx_sunlock(&fvdat->fh_lock); return (err); }