From owner-svn-src-stable@freebsd.org Tue Mar 6 03:14:31 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A2C79F47926 for ; Tue, 6 Mar 2018 03:14:31 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yw0-x22f.google.com (mail-yw0-x22f.google.com [IPv6:2607:f8b0:4002:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D6A6E7DDC8 for ; Tue, 6 Mar 2018 03:14:30 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yw0-x22f.google.com with SMTP id g198so6447494ywb.3 for ; Mon, 05 Mar 2018 19:14:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=tfnceKhelMDBxk6AHSAxeznShW+ukR5WeYPMWOTI3hY=; b=RRetPRTyAG6vow8KEIbHvbVmzwpMngWkaeT+t7Nw4dorVFogcDYBFJjHL6RygMcZZB n2n3mNR0NHVG7J5rEo+hnvY5BUlO4nPlHf2rsX0xf0gW5MNXb1TS0f0kC8y8dqHPe9OU U434Uce9GWnsfU8iyRYpvrZBmrvKuq8ceXJ8U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=tfnceKhelMDBxk6AHSAxeznShW+ukR5WeYPMWOTI3hY=; b=KHs5De9k7RrWOrjFbr7bO2kmdNDDL+hgki3WDQJc/g1QqrZsYNi5Tm8lvQiyGfWfJM 8Of6PFyr3b5SfAI3J2svJJqDDnWu4IgPLqvR6vB7HFXziA6gbvLWmXPsIp+9nWdYnESY UGapE4wJ1lEYhPTOU2A2xW8lzPBeb/r++n/M7Cl8Ipc1lqyh8aT94B8blDQ0wFpEa37G CWBIEfi611+Ff5A2tPmuLDNKeACO24uBXkOqBhlPFtjjFOKSEquJWMHlBbBOc8aU129J 83rnqa8dADfPmwKUHacuHbBu5edbHVsO51YmuaWiZltkJFFclGmA8RoAJHXmPmB2QPHu BnGQ== X-Gm-Message-State: AElRT7F+58FtVWv6QYs1pKuOdSYjZS3izKJe5Un7DFwSNfhpquoXrlUx y6ghAwy5B0KDkvaJrAEsaFkXRuClp9eBxFYAqFsrgA== X-Google-Smtp-Source: AG47ELuyYnRtLSNUYdgHIpdJR+e4mUim3WO0h6w+zkKoPCU+aibA+X6Z5K24Qpw+m4gkGs5FFLmjY2XWpLZQUInD4Nw= X-Received: by 10.13.214.214 with SMTP id y205mr10508798ywd.37.1520306070158; Mon, 05 Mar 2018 19:14:30 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 2002:a25:23d2:0:0:0:0:0 with HTTP; Mon, 5 Mar 2018 19:13:59 -0800 (PST) In-Reply-To: <1861296.ksaTdANMae@ralph.baldwin.cx> References: <201803050754.w257swAE001435@repo.freebsd.org> <1861296.ksaTdANMae@ralph.baldwin.cx> From: Eitan Adler Date: Mon, 5 Mar 2018 19:13:59 -0800 X-Google-Sender-Auth: J7a39vVd4xhfAI8WzE9WwBXqTsM Message-ID: Subject: Re: svn commit: r330451 - in stable/11/sys: dev/iwm dev/otus dev/usb/wlan net80211 To: John Baldwin Cc: src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2018 03:14:31 -0000 On 5 March 2018 at 10:08, John Baldwin wrote: > On Monday, March 05, 2018 07:54:58 AM Eitan Adler wrote: >> Author: eadler >> Date: Mon Mar 5 07:54:57 2018 >> New Revision: 330451 >> URL: https://svnweb.freebsd.org/changeset/base/330451 >> >> Log: >> MFC r306837: >> >> [net80211] extend the ieee80211_rx_stats struct to include more information. > > Have you thought about the KBI implications of this change and some of the > other changes you've merged? I do have a copy of the modules from 11.1 and have loaded them at various points in time after merging. That said, I am not perfect. Unfortunately, my -STABLE box did not have fully functioning drivers before these changes so its difficult to test anything beyond "loads and does not panic.". I havn't done so today yet, but that will happen soon. Ensuring these things work through code inspection is certainly possible and I've skipped over several changes as a result. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams