From owner-svn-src-head@freebsd.org Tue Nov 17 22:41:50 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3E6E24714FA; Tue, 17 Nov 2020 22:41:50 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CbLXY12RCz3pwF; Tue, 17 Nov 2020 22:41:48 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 0AHMffQx086733; Tue, 17 Nov 2020 14:41:41 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 0AHMffWK086732; Tue, 17 Nov 2020 14:41:41 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202011172241.0AHMffWK086732@gndrsh.dnsmgr.net> Subject: Re: svn commit: r367678 - head/usr.sbin/freebsd-update In-Reply-To: To: Kyle Evans Date: Tue, 17 Nov 2020 14:41:41 -0800 (PST) CC: Mateusz Piotrowski <0mp@freebsd.org>, "Rodney W. Grimes" , src-committers , svn-src-all , svn-src-head Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4CbLXY12RCz3pwF X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd@gndrsh.dnsmgr.net X-Spamd-Result: default: False [-2.10 / 15.00]; HAS_REPLYTO(0.00)[rgrimes@freebsd.org]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[69.59.192.140:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[6]; SPAMHAUS_ZRD(0.00)[69.59.192.140:from:127.0.2.255]; RCVD_TLS_LAST(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-0.998]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2020 22:41:50 -0000 > On Sat, Nov 14, 2020 at 11:20 AM Mateusz Piotrowski <0mp@freebsd.org> wrote: > > > > Hello Rodney, > > > > On 11/14/20 4:59 PM, Rodney W. Grimes wrote: > > >> Author: 0mp (doc,ports committer) > > >> Date: Sat Nov 14 13:07:41 2020 > > >> New Revision: 367678 > > >> URL: https://svnweb.freebsd.org/changeset/base/367678 > > >> > > >> Log: > > >> Document the PAGER environment variable > > >> > > >> Sometimes users want to use freebsd-update(8) in a non-interactive way and > > >> what they often miss is that they have to set PAGER to cat(1) in order to > > >> avoid interactive prompts from less(1). > > > Which was caused by the change of invoking more(1) as less(1) causing > > > this regression, as when invoked as more(1) it falls off the end of > > > empty input and causes no such interactive prompt. > > > > > > Setting PAGER to more(1) also fixes this. > > > > Mmm, I'm not sure if that would work. If I run "jot 1000 | more" in my terminal I still get an > > interactive prompt. Could it be that you are referring to a different more(1) implementation? I'm > > clearly missing something. > > Part of what your missing is freebsd-update(8) often outputs a 0 length file which less(1) well want you to respond Quit to before going to the next file. more(1) does not do that. jot 1000 produces 1 x 1000 line file, that is not whats causing the issues with freebsd-update and less(1), it is more like 1000 x 1 line files. > > more(1) is more or less like `less -E`, which is a default PAGER I had > advocated for back when it changed. It can be mostly non-interactive > as long as your diffs are small, but it's definitely much less > painful. Yes, that would of been less painful, note that iirc there are a few other places effected in similiar ways with 0 line output files sent to less(1) that cause a need to hit a bunch of q's to get the command completed. Since I am an aged more(1) user I just globally fix PAGER. It would of been far less painful had PAGER simply been changed to less rather than all the binary invokations beeing changed, but hind sight is amazing. -- Rod Grimes rgrimes@freebsd.org