From owner-freebsd-usb@FreeBSD.ORG Tue Dec 23 17:59:13 2008 Return-Path: Delivered-To: freebsd-usb@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5143B1065673 for ; Tue, 23 Dec 2008 17:59:13 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211]) by mx1.freebsd.org (Postfix) with ESMTP id E6C9F8FC21 for ; Tue, 23 Dec 2008 17:59:12 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: by palm.hoeg.nl (Postfix, from userid 1000) id 09E921CFED; Tue, 23 Dec 2008 18:59:12 +0100 (CET) Date: Tue, 23 Dec 2008 18:59:11 +0100 From: Ed Schouten To: freebsd-usb@FreeBSD.org Message-ID: <20081223175911.GZ1176@hoeg.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vD4R8EutdGn5UgVK" Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Cc: Subject: Giant on serial devices in USB2? X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Dec 2008 17:59:13 -0000 --vD4R8EutdGn5UgVK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello HPS, others, I was just running a grep on the USB2 code and saw the following: $ grep -r Giant sys/dev/usb2/serial | wc -l 70 WHat's the exact reason USB2 still uses Giant on TTY related drivers? Couldn't it just use the per-TTY mutex? If not, maybe it should create a custom system-wide mutex, instead of using Giant? Yours, --=20 Ed Schouten WWW: http://80386.nl/ --vD4R8EutdGn5UgVK Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAklRJu8ACgkQ52SDGA2eCwWBQgCbBccazYyrrHNM1eRj2CJF8ZjF 6dMAn2XZK7zgDYR+9vRw/XU3ycMdbxmZ =JLWf -----END PGP SIGNATURE----- --vD4R8EutdGn5UgVK--