Date: Tue, 23 Aug 2011 13:12:30 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Greg Larkin <glarkin@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, C-S <c-s@c-s.li>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/hiawatha Makefile ports/www/hiawatha/files hiawatha.in php-fcgi.in pkg-message.in Message-ID: <4E5409AE.9050400@FreeBSD.org> In-Reply-To: <201108232003.p7NK3ZQx066601@repoman.freebsd.org> References: <201108232003.p7NK3ZQx066601@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
The rc.d script looks good, thanks!
The only thing I would do differently is instead of having 2 separate lines:
: ${hiawatha_pidfile="/var/run/hiawatha.pid"}
pidfile=${hiawatha_pidfile}
Do it like this:
pidfile=${hiawatha_pidfile="/var/run/hiawatha.pid"}
But that's really a micro-optimization.
Thanks again,
Doug
On 08/23/2011 13:03, Greg Larkin wrote:
> glarkin 2011-08-23 20:03:35 UTC
>
> FreeBSD ports repository
>
> Modified files:
> www/hiawatha Makefile
> www/hiawatha/files hiawatha.in pkg-message.in
> Added files:
> www/hiawatha/files php-fcgi.in
> Log:
> - Added rc.d file for php-fcgi (Hiawatha FastCGI daemon)
> - Cleanups in hiawatha rc.d file
> - Bumped PORTREVISION
>
> PR: ports/158944 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=158944
> Submitted by: C-S <c-s@c-s.li> (maintainer)
>
> Revision Changes Path
> 1.32 +2 -1 ports/www/hiawatha/Makefile
> 1.3 +19 -7 ports/www/hiawatha/files/hiawatha.in
> 1.1 +36 -0 ports/www/hiawatha/files/php-fcgi.in (new)
> 1.5 +3 -0 ports/www/hiawatha/files/pkg-message.in
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/hiawatha/Makefile.diff?&r1=1.31&r2=1.32&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/hiawatha/files/hiawatha.in.diff?&r1=1.2&r2=1.3&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/hiawatha/files/php-fcgi.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/hiawatha/files/pkg-message.in.diff?&r1=1.4&r2=1.5&f=h
>
--
Nothin' ever doesn't change, but nothin' changes much.
-- OK Go
Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E5409AE.9050400>