From owner-freebsd-bugs  Sun Jul 15 10:52:51 2001
Delivered-To: freebsd-bugs@freebsd.org
Received: from iatl0x01.coxmail.com (iatl1x01.coxmail.com [206.157.231.23])
	by hub.freebsd.org (Postfix) with ESMTP id 549B637B403
	for <freebsd-bugs@FreeBSD.org>; Sun, 15 Jul 2001 10:52:46 -0700 (PDT)
	(envelope-from mheffner@novacoxmail.com)
Received: from enterprise.muriel.penguinpowered.com ([208.138.198.178])
          by iatl0x01.coxmail.com
          (InterMail vK.4.03.02.00 201-232-124 license 85f4f10023be2bd3bce00b3a38363ea2)
          with ESMTP
          id <20010715175244.DBSI2144.iatl0x01@enterprise.muriel.penguinpowered.com>;
          Sun, 15 Jul 2001 13:52:44 -0400
Message-ID: <XFMail.20010715135109.mheffner@novacoxmail.com>
X-Mailer: XFMail 1.5.0 on FreeBSD
X-Priority: 3 (Normal)
MIME-Version: 1.0
Content-Type: multipart/signed;
 boundary="_=XFMail.1.5.0.FreeBSD:20010715135109:57103=_";
 micalg=pgp-md5; protocol="application/pgp-signature"
In-Reply-To: <200107151730.f6FHU1f96888@freefall.freebsd.org>
Date: Sun, 15 Jul 2001 13:51:09 -0400 (EDT)
Reply-To: Mike Heffner <mheffner@vt.edu>
From: Mike Heffner <mheffner@novacoxmail.com>
To: Chris Faulhaber <jedgar@fxp.org>
Subject: Re: bin/28990: ftp(1) has stack overflow when "mget *", etc.
Cc: freebsd-bugs@FreeBSD.org
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

This message is in MIME format
--_=XFMail.1.5.0.FreeBSD:20010715135109:57103=_
Content-Type: text/plain; charset=us-ascii


On 15-Jul-2001 Chris Faulhaber wrote:
| The following reply was made to PR bin/28990; it has been noted by GNATS.
| 
| From: Chris Faulhaber <jedgar@fxp.org>
| To: SASAKI Taroh <taroh@taroh.org>
| Cc: freebsd-gnats-submit@FreeBSD.org
| Subject: Re: bin/28990: ftp(1) has stack overflow when "mget *", etc.
| Date: Sun, 15 Jul 2001 13:23:58 -0400
| 
|  --d6Gm4EdcadzBjdND
|  Content-Type: text/plain; charset=us-ascii
|  Content-Disposition: inline
|  Content-Transfer-Encoding: quoted-printable
|  
|  On Sun, Jul 15, 2001 at 08:59:28AM -0700, SASAKI Taroh wrote:
|  >=20
|  > >Fix:
|  > *** usr/src/usr.bin/ftp/util.c  Mon Jul 16 00:45:11 2001
|  > --- usr/src/usr.bin/ftp/util.c.org      Mon Jul 16 00:37:57 2001
|  > ***************
|  > *** 371,377 ****
|  >                   hash =3D 0;
|  >                   if (doswitch)
|  >                           pswitch(!proxy);
|  > !                 for (mode =3D "w", ++argv; *argv !=3D NULL; argv++, mod=
|  e =3D "a")
|  
|  I don't seem to be able to locate this piece of code in util.c.
|  According to cvsweb, the 'fix' has been in the tree since rev 1.1.

Well, the diff is backwards. However, I haven't looked at the code throughly
enough yet to be able to tell whether this is actually a problem.

Mike

-- 
  Mike Heffner         <mheffner@[acm.]vt.edu>
  Fredericksburg, VA       <mikeh@FreeBSD.org>


--_=XFMail.1.5.0.FreeBSD:20010715135109:57103=_
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org

iD8DBQE7UdgNFokZQs3sv5kRAnGSAKCLkPYEPKbbMk5sH/G3h6eiyHeQKQCfXaPg
1ZoWb2wb7lJNhyROb1COFQg=
=WJCg
-----END PGP SIGNATURE-----

--_=XFMail.1.5.0.FreeBSD:20010715135109:57103=_--
End of MIME message

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message