From owner-svn-src-head@FreeBSD.ORG  Wed Apr 15 20:58:17 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 11F181065673;
	Wed, 15 Apr 2009 20:58:17 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211])
	by mx1.freebsd.org (Postfix) with ESMTP id A2FEE8FC1B;
	Wed, 15 Apr 2009 20:58:16 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id 752F21CFFA; Wed, 15 Apr 2009 22:58:15 +0200 (CEST)
Date: Wed, 15 Apr 2009 22:58:15 +0200
From: Ed Schouten <ed@80386.nl>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20090415205815.GA58540@hoeg.nl>
References: <200904151958.n3FJwfqD052982@svn.freebsd.org>
	<200904151632.41653.jhb@freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY"
Content-Disposition: inline
In-Reply-To: <200904151632.41653.jhb@freebsd.org>
User-Agent: Mutt/1.5.19 (2009-01-05)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r191114 - head/sys/pc98/cbus
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Apr 2009 20:58:18 -0000


--OXfL5xGRrasGEqWY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello John,

* John Baldwin <jhb@freebsd.org> wrote:
> When I performed similar changes in lpt(4) I stored the flags in si_drv2=
=20
> instead of the minor number.  You might want to do the same here so the=
=20
> drivers are closer.

I guess in the very far future we'll hopefully just get rid of
dev2unit() and allow the struct field that stores the unit number
(si_drv0) to be used by the drivers directly. An advantage of the unit
number is that it's an integer type, unlike si_drv1 and si_drv2.

I guess it's good to just leave it the way it is right now, because it
was the least intrusive way to fix it like this and best of all, if I
ever get the chance to remove dev2unit(), I'm forced to let it use
si_drv0 instead of keeping evil casts from/to pointers.

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--OXfL5xGRrasGEqWY
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAknmSmcACgkQ52SDGA2eCwX2GQCfbuLU+H7LUa/Cir3Fr/lPBmFS
8dwAnjZwzxY2LTqag+/IuZJDr1GCms7Y
=PE5l
-----END PGP SIGNATURE-----

--OXfL5xGRrasGEqWY--