From owner-svn-ports-all@FreeBSD.ORG Sun Jul 20 22:46:36 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A0A94F53; Sun, 20 Jul 2014 22:46:36 +0000 (UTC) Received: from mailrelay003.isp.belgacom.be (mailrelay003.isp.belgacom.be [195.238.6.53]) by mx1.freebsd.org (Postfix) with ESMTP id 6F20924D6; Sun, 20 Jul 2014 22:46:34 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjQMAI9FzFNbs4jr/2dsb2JhbABZgw5STQvFKYdEAYEHF3aEBAEFViMQCw4GBAklDyoeBohZAQjAAxePOhEHhEYFkkCIZIFOkmKDRjs Received: from 235.136-179-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.179.136.235]) by relay.skynet.be with ESMTP; 21 Jul 2014 00:45:23 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id s6KMjMh9006067; Mon, 21 Jul 2014 00:45:22 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Mon, 21 Jul 2014 00:45:17 +0200 From: Tijl Coosemans To: Baptiste Daroussin Subject: Re: svn commit: r362304 - head/x11-toolkits/pango Message-ID: <20140721004517.2f82e183@kalimero.tijl.coosemans.org> In-Reply-To: <20140720212754.GG26778@ivaldir.etoilebsd.net> References: <201407200815.s6K8FG8b003096@svn.freebsd.org> <20140720132259.156d687e@kalimero.tijl.coosemans.org> <53CBA770.2010409@marino.st> <20140720113124.GD26778@ivaldir.etoilebsd.net> <20140720165256.1f4d5d07@kalimero.tijl.coosemans.org> <20140720212754.GG26778@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/noQpJGUNoddeAxT5+s=mtN_"; protocol="application/pgp-signature" Cc: svn-ports-head@freebsd.org, kwm@FreeBSD.org, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2014 22:46:36 -0000 --Sig_/noQpJGUNoddeAxT5+s=mtN_ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 20 Jul 2014 23:27:54 +0200 Baptiste Daroussin wrote: > On Sun, Jul 20, 2014 at 04:52:56PM +0200, Tijl Coosemans wrote: >> On Sun, 20 Jul 2014 13:31:24 +0200 Baptiste Daroussin wrote: >>> On Sun, Jul 20, 2014 at 01:26:40PM +0200, John Marino wrote: >>>> On 7/20/2014 13:22, Tijl Coosemans wrote: >>>>> On Sun, 20 Jul 2014 08:15:16 +0000 (UTC) John Marino wrote: >>>>>> Author: marino >>>>>> Date: Sun Jul 20 08:15:16 2014 >>>>>> New Revision: 362304 >>>>>> URL: http://svnweb.freebsd.org/changeset/ports/362304 >>>>>> QAT: https://qat.redports.org/buildarchive/r362304/ >>>>>> >>>>>> Log: >>>>>> x11-toolkits/pango: require explicit linking >>>>>> =20 >>>>>> This new configure argument will list all required libraries in the >>>>>> generated pkgconf files. Before any library indirectly pulled in,= such >>>>>> as libm, was not listed. >>>>>> =20 >>>>>> This fixes numerous regression in dports and it's more correct any= way. >>>>>=20 >>>>> No, this is wrong. Each port should link to the libraries it needs on >>>>> its own. No port should rely on other ports to pull in libraries for >>>>> them. >>>>=20 >>>> Then I guess we really don't need pkgconfig .pc files at all then? >>>> (This is the point of .pc files, it tells how to link. libm is direct= ly >>>> used by pango) >>>>=20 >>>> so no, it is not wrong. The generated pc file was wrong, now it's not. >>>> This is why the configuration argument exists. >>=20 >> A .pc file normally has 1 library in the Libs field (the library the .pc >> file is created for) and 0 items in the Requires field. Dependencies go >> in the Libs.private or Requires.private fields. The only reason to add >> dependencies to Libs or Requires is if the headers of the library expose >> the API of those dependencies (e.g. the library headers define macros or >> inline functions that expand to calls to functions in a dependency (such >> as Gtk macros that expand to Glib function calls)). >>=20 >> The pango headers don't even include math.h or complex.h so they cannot >> expose its API. The generated .pc file was correct, now it is wrong. >>=20 >> The reason the configure argument exists is probably because this is an >> old .pc file from before the .private fields existed. >>=20 >>> The good question is "does pango exposes parts of libm or not?" if yes >>> then libm should be listed in the libraries of pango.pc is not it should >>> only appears in the private field. > > Libs.private are also there to handle the needed library when something > request static linking so having -lm in libs.private could make sense >=20 > Otherwise I do agrree Yes, -lm could be added to Libs.private but the port doesn't provide static pango libraries so it's not necessary to patch the .pc file for static linking. --Sig_/noQpJGUNoddeAxT5+s=mtN_ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlPMRoEACgkQfoCS2CCgtis/aQD/Y1CpJgt+v9VW6n27L67n/fyB Mq2io2RWXIt/W5KYs0AA/16MZTO1zK+SEsZWD+SBfhhwvngolKPgDUUgzpIf/y3B =jL4q -----END PGP SIGNATURE----- --Sig_/noQpJGUNoddeAxT5+s=mtN_--