From owner-freebsd-security@freebsd.org Mon Oct 10 23:30:07 2016 Return-Path: Delivered-To: freebsd-security@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7A02AC07BA7 for ; Mon, 10 Oct 2016 23:30:07 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 57832E38 for ; Mon, 10 Oct 2016 23:30:06 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id u9ANU5PQ059352 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 10 Oct 2016 16:30:05 -0700 (PDT) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id u9ANU5iK059351; Mon, 10 Oct 2016 16:30:05 -0700 (PDT) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 10 Oct 2016 16:30:04 -0700 From: Gleb Smirnoff To: "George L. Yermulnik" Cc: freebsd-security@freebsd.org Subject: Re: FreeBSD Security Advisory FreeBSD-SA-16:31.libarchive Message-ID: <20161010233004.GG23123@FreeBSD.org> References: <20161010075202.0C4281857@freefall.freebsd.org> <20161010204456.GA57293@yz.kiev.ua> <20161010212342.GF23123@FreeBSD.org> <20161010213743.GE57293@yz.kiev.ua> <20161010214625.GF57293@yz.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161010214625.GF57293@yz.kiev.ua> User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: freebsd-security@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Security issues \[members-only posting\]" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2016 23:30:07 -0000 On Tue, Oct 11, 2016 at 12:46:25AM +0300, George L. Yermulnik wrote: G> Hello! G> G> On Tue, 11 Oct 2016 at 00:37:43 (+0300), George L. Yermulnik wrote: G> G> > > https://security.FreeBSD.org/patches/SA-16:31/libarchive-10.1.patch G> > > https://security.FreeBSD.org/patches/SA-16:31/libarchive-10.2.patch G> > > https://security.FreeBSD.org/patches/SA-16:31/libarchive-10.3.patch G> G> > Thanx. I found that already, but Security Advisory is incorrect and that's the point. G> > Anyway libarchive-10.3.patch generated on my 10.3 box a bunch of rejections, G> > so I had to checkout contrib/libarchive/libarchive/ and lib/libarchive/tests/ from repository G> > to be able to rebuild world. G> G> Though I'm not able: G> [--- cut ---] G> --- archive_read_disk_posix.So --- G> cc -fpic -DPIC -DHAVE_ICONV=1 -DHAVE_ICONV_H=1 -DICONV_CONST= -O2 -pipe -DHAVE_BZLIB_H=1 -DHAVE_L G> IBLZMA=1 -DHAVE_LZMA_H=1 -DPLATFORM_CONFIG_H=\"/usr/src/lib/libarchive/config_freebsd.h\" -I/usr/obj G> /usr/src/lib/libarchive -DWITH_OPENSSL -std=gnu99 -Qunused-arguments -fstack-protector -Wsystem-hea G> ders -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes G> -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wch G> ar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wmissing-variable- G> declarations -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -c / G> usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_disk_posix.c -o archive_read G> _disk_posix.So G> /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_disk_posix.c:1577:37: error G> : incompatible pointer types passing 'struct vfsconf *' to parameter of type 'struct xvfsconf *' [-W G> error,-Wincompatible-pointer-types] G> r = getvfsbyname(sfs.f_fstypename, &vfc); G> ^~~~ G> /usr/obj/usr/src/tmp/usr/include/sys/mount.h:947:49: note: passing argument to parameter here G> int getvfsbyname(const char *, struct xvfsconf *); G> ^ G> 1 error generated. G> *** [archive_read_disk_posix.So] Error code 1 G> [--- cut ---] G> G> FreeBSD 10.3-STABLE i386 If it is a 10.3-STABLE system, you should just 'svn up' and rebuild, because patch is already included into the stable/10 branch. The patches are for those who run releases. -- Totus tuus, Glebius.