From owner-freebsd-current@FreeBSD.ORG Wed Nov 7 15:32:28 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 16B06C92 for ; Wed, 7 Nov 2012 15:32:28 +0000 (UTC) (envelope-from kaduk@mit.edu) Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU [18.7.68.37]) by mx1.freebsd.org (Postfix) with ESMTP id A3CB28FC12 for ; Wed, 7 Nov 2012 15:32:27 +0000 (UTC) X-AuditID: 12074425-b7fcc6d00000091f-db-509a7f0a4b37 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP id 6B.BF.02335.A0F7A905; Wed, 7 Nov 2012 10:32:26 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id qA7FWQIq027926; Wed, 7 Nov 2012 10:32:26 -0500 Received: from multics.mit.edu (SYSTEM-LOW-SIPB.MIT.EDU [18.187.2.37]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qA7FWOWt028274 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 7 Nov 2012 10:32:25 -0500 (EST) Received: (from kaduk@localhost) by multics.mit.edu (8.12.9.20060308) id qA7FWNt6023414; Wed, 7 Nov 2012 10:32:23 -0500 (EST) Date: Wed, 7 Nov 2012 10:32:23 -0500 (EST) From: Benjamin Kaduk To: Larry Rosenman Subject: Re: sysutils/lsof Author Question (for CLANG).... In-Reply-To: <5d4c4abe37bd6fffd0c206c1b7b68ce1@webmail.lerctr.org> Message-ID: References: <5d4c4abe37bd6fffd0c206c1b7b68ce1@webmail.lerctr.org> User-Agent: Alpine 1.10 (GSO 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsUixCmqrMtVPyvAYN0HK4s5bz4wWSx/MIvV gcljxqf5LB77925lCWCK4rJJSc3JLEst0rdL4Mp4s/QHW8Fs9oq7WyayNjDeZO1i5OSQEDCR +D93LjOELSZx4d56ti5GLg4hgX2MEn/WfWWBcNYzSpy9vJIVwjnOJDHr7md2kBYhgXqJTWcX gbWzCGhJ9H5ZwQRiswmoSMx8s5ENxBYRUJZYM/UPWA2zgLzE/yuXwWqEBawkOq4dALM5BZwk Nj1dA2bzCjhI/D17irGLkQNovqPEvQvCIGFRAR2J1funsECUCEqcnPmEBWKkpcS/tb9YJzAK zkKSmoUktYCRaRWjbEpulW5uYmZOcWqybnFyYl5eapGuhV5uZoleakrpJkZQoLK7qO5gnHBI 6RCjAAejEg9vQ+TMACHWxLLiytxDjJIcTEqivMeqZwUI8SXlp1RmJBZnxBeV5qQWH2KU4GBW EuFlKQTK8aYkVlalFuXDpKQ5WJTEeW+k3PQXEkhPLEnNTk0tSC2CycpwcChJ8L6pBWoULEpN T61Iy8wpQUgzcXCCDOcBGs5QBzK8uCAxtzgzHSJ/ilFRSpz3JkizAEgiozQPrheWSF4xigO9 Isz7DqSKB5iE4LpfAQ1mAhpcfG0GyOCSRISUVAPjKv4lbH5vJ1a3+zl6XgyRvCfpFWsUqxgp 1/x8T/KR2Yzt38zO3Sy077DZvCbo663nsbHBD1vVT1e93nX/Glu3qvyzKX8ZZdY+fG6Q/uP/ vhfmEmWK3w7eqntV/Wjjw/LGU41F6wyj11+o3Lv77ao5fe9KN2x0+ByodTBz8+syhuj1d95t kfrRpMRSnJFoqMVcVJwIAGu4vur/AgAA Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2012 15:32:28 -0000 On Wed, 7 Nov 2012, Larry Rosenman wrote: > Vic Abell (the lsof author) asked me the following: > In adjusting for clang I have come up with an unanswered > question. Where is the VOP_UNLOCK() macro defined? > > I've done a full search of all the files in /usr/src/sys > and can't find its definition, but I find many, many > uses. > > Perhaps someone on the freebsd-current list knows. > > Can someone help me help him? It is defined in vnode_if.h, generated as part of the kernel build process. The source file is sys/kern/vnode_if.src, and look at sys/tools/vnode_if.awk and sys/conf/kmod.mk for how it is used. Once again, attempting to use kernel internals outside of the supported interfaces is just asking for trouble; I do not understand why this message is not sinking in over the course of your previous mails to these lists, so I will not try to belabor it further. -Ben Kaduk