From owner-freebsd-current@FreeBSD.ORG Sat Jul 27 14:50:56 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9A3D8D82 for ; Sat, 27 Jul 2013 14:50:56 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm26-vm6.bullet.mail.ne1.yahoo.com (nm26-vm6.bullet.mail.ne1.yahoo.com [98.138.91.119]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 42FCD288D for ; Sat, 27 Jul 2013 14:50:56 +0000 (UTC) Received: from [98.138.226.179] by nm26.bullet.mail.ne1.yahoo.com with NNFMP; 27 Jul 2013 14:48:06 -0000 Received: from [98.138.84.41] by tm14.bullet.mail.ne1.yahoo.com with NNFMP; 27 Jul 2013 14:48:06 -0000 Received: from [127.0.0.1] by smtp109.mail.ne1.yahoo.com with NNFMP; 27 Jul 2013 14:48:06 -0000 X-Yahoo-Newman-Id: 103804.50300.bm@smtp109.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: pQFWW8cVM1lU3_o3fS6bR2W_jn54wtv7L.i6X.Qs.FOsVuE iPXmGevMvGdGHREo5b8TZigH5JFuPtletDx7XZUXksY7XynwAr7TULIzTtne WCRFSqsZbEyEXxvvhqDCNJqgjXZuBcJtHpSqDHiP3Vyq5xunbodF2fUeW_xu IotY0N5DpaGAWh.nNX5h8Y3OYBvEhChIOXQ7bOJJ1Dnx7Fj0Cif6zr3JI56g fXR.dHq8oqK7xr13U2_iHvRTLpcq3wYISfsHl8sJrmvNBA7Gmh4.h.Cp_88H Jal7kjYKC_WW8wq9xnpz_cab.5lKDnef0MCoYU1te1xMDHZe6E_aTam2lLtz tMWW3baDAB6rXeXDaePqKU0i6dFpGhc1FO9LCPh7mAsYVCRaAERN6.HRh70s cHtJCtuIgQaLIEbGPEJGl1EYNVITsYuutAdunsz0nsqZVOB.DI2YgLfcePPy 4t.m0MCNYpMMfaR4S2gNwEDC95f.UyM4Xd_672jac.BmUQIEfiWuMwr8NCIg 4_w79VSvgCGxHjCw- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf X-Rocket-Received: from [192.168.0.102] (pfg@190.157.126.109 with ) by smtp109.mail.ne1.yahoo.com with SMTP; 27 Jul 2013 07:48:05 -0700 PDT Message-ID: <51F3DDA3.8010606@FreeBSD.org> Date: Sat, 27 Jul 2013 09:48:03 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130630 Thunderbird/17.0.7 MIME-Version: 1.0 To: Jan Beich Subject: Re: [Heads up] BSD-licensed patch becoming the default RSN. References: <51F2E627.9090907@FreeBSD.org> <1V2ssp-000Nrk-Q8@internal.tormail.org> <51F32288.7050701@FreeBSD.org> <1V2vqT-000JNd-DJ@internal.tormail.org> In-Reply-To: <1V2vqT-000JNd-DJ@internal.tormail.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: FreeBSD Current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jul 2013 14:50:56 -0000 On 26.07.2013 23:11, Jan Beich wrote: > Pedro Giffuni writes: > >> Now, just some food for thought, but if you are unsure your patch >> applies cleanly, why would you choose to use the -s (silent) option? > Because by default patch(1) is overly verbose. At first, I'm only > interested if a patch applies cleanly, then what files fail to apply. > To fix the patch I just repeat over edit a hunk (or two) and confirm > patch(1) no longer rejects it. > > With -Cs giving up is easy at any time. One may not care about > a failed hunk in a man page or prefer to edit a patch as the whole > instead of on per-file (.rej file) basis. I would tend to do -Cs just to see if it applies cleanly or not and if there is a failure then do -C to see the failure. Actually I always use -C from the start. In any case, I find it reasonable to want to preserve the GNU patch behaviour. The code is rather simple so I would encourage other interested people to look at it, or I will look at it at a later time. Pedro.