From owner-freebsd-arch@FreeBSD.ORG Mon Oct 2 07:46:42 2006 Return-Path: X-Original-To: arch@FreeBSD.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3762B16A407 for ; Mon, 2 Oct 2006 07:46:42 +0000 (UTC) (envelope-from rink@rink.nu) Received: from mx0.rink.nu (thunderstone.rink.nu [80.112.228.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id B4AC343D53 for ; Mon, 2 Oct 2006 07:46:41 +0000 (GMT) (envelope-from rink@rink.nu) Received: from localhost (localhost [127.0.0.1]) by mx0.rink.nu (Postfix) with ESMTP id 3A4A317011 for ; Mon, 2 Oct 2006 09:47:03 +0200 (CEST) X-Virus-Scanned: amavisd-new at rink.nu Received: from mx0.rink.nu ([127.0.0.1]) by localhost (thunderstone.rink.nu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9m1zigjfDLN0 for ; Mon, 2 Oct 2006 09:47:00 +0200 (CEST) Received: by mx0.rink.nu (Postfix, from userid 1000) id E1AA717072; Mon, 2 Oct 2006 09:46:59 +0200 (CEST) Date: Mon, 2 Oct 2006 09:46:59 +0200 From: Rink Springer To: arch@FreeBSD.org Message-ID: <20061002074659.GA26895@rink.nu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UlVJffcvxoiEqYs2" Content-Disposition: inline User-Agent: Mutt/1.5.11 Cc: Subject: [RFC] mountd(8) patch to prevent flag removal X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Oct 2006 07:46:42 -0000 --UlVJffcvxoiEqYs2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, At work, we recently moved our local webserver storage (which was plain UFS along with the SUIDDIR mount option) to a separate NFS server. However, upon NFS-exporting the filesystem from the NFS server (where it was mounted usin= g -o suiddir as well), this flag would vanish. It turns out that this is due to a refactoring in mountd(8). I initially ma= iled Craig Rodrigues about this, who did the refactoring, but I haven't received= any reply. The problem is introduced in usr.sbin/mountd/mountd.c revision 1.81.2.2; it uses nmount(2) with a flags argument of 0 to remount the filesystem. Unfortunately, this means any specific mount-flags are removed from the filesystem. The patch to fix this is at http://rink.nu/tmp/mountd.c.diff; which I'd like to commit to -HEAD and MFC later on. Would anyone be so kind to review this? Thanks, --=20 Rink P.W. Springer - http://rink.nu "When will the internet move from 64Kb max .com domains to .exe domains which can use much more memory?" - Edwin Groothuis --UlVJffcvxoiEqYs2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQFFIMPzb3O60uztv/8RAp1CAJ45TaNLQsPR9NN8tPJl8IFGgfPY1ACgsksl 6tioGlPzSUan1uO3hXGhd3o= =l+UN -----END PGP SIGNATURE----- --UlVJffcvxoiEqYs2--