From owner-cvs-all  Fri Jan  4 16:39:39 2002
Delivered-To: cvs-all@freebsd.org
Received: from vega.dmnshq.net (vega.dmnshq.net [194.19.34.94])
	by hub.freebsd.org (Postfix) with SMTP
	id 884B737B41A; Fri,  4 Jan 2002 16:39:26 -0800 (PST)
Received: (from eivind@localhost)
	by vega.dmnshq.net (8.11.6/8.9.3) id g04Entw12240;
	Fri, 4 Jan 2002 15:49:55 +0100 (CET)
	(envelope-from eivind)
Date: Fri, 4 Jan 2002 15:49:54 +0100
From: Eivind Eklund <eivind@FreeBSD.org>
To: Julian Elischer <julian@elischer.org>
Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject: Re: cvs commit: src/share/man/man3 queue.3
Message-ID: <20020104154954.A12125@FreeBSD.org>
References: <200201030919.g039J8v63350@apollo.backplane.com> <Pine.BSF.4.21.0201030138380.22265-100000@InterJet.elischer.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <Pine.BSF.4.21.0201030138380.22265-100000@InterJet.elischer.org>; from julian@elischer.org on Thu, Jan 03, 2002 at 01:43:02AM -0800
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, Jan 03, 2002 at 01:43:02AM -0800, Julian Elischer wrote:
> On Thu, 3 Jan 2002, Matthew Dillon wrote:
> >     The issue here is to extend an abstraction up to the point where
> >     the compiler can easily optimize it.
> 
> Bugger the compiler, I want readable code..
> :-)

So do I.  And for that reason I'm strongly opposed to your idea.

Without your change, I can view the available queue types as green, pink, and
yellow, and mostly ignore what the differences between green, pink and yellow
queues are.

With your change, I have to memorize that pink queues set p to NULL when they
are through iterating.  This makes the code LESS readable, overall.  It makes
it about as easy to read when you HAVE memorized that pink queues set p to
NULL when they are through iterating - and have memorized it so well that it
is as internalized as the basic syntax of the C language.

Please fix your code instead of making the documentation say your way is
acceptable.  It makes the code less readable for a lot of people out here.

Eivind.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message