From owner-cvs-sys Fri Mar 17 20:00:37 1995 Return-Path: cvs-sys-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id UAA10182 for cvs-sys-outgoing; Fri, 17 Mar 1995 20:00:37 -0800 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id UAA10176; Fri, 17 Mar 1995 20:00:29 -0800 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.8/8.6.6) id TAA20189; Fri, 17 Mar 1995 19:58:50 -0800 From: "Rodney W. Grimes" Message-Id: <199503180358.TAA20189@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/sys/libkern locc.c random.c scanc.c skpc.c libkern.h To: davidg@Root.COM Date: Fri, 17 Mar 1995 19:58:50 -0800 (PST) Cc: bde@zeta.org.au, CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com In-Reply-To: <199503180236.SAA00333@corbin.Root.COM> from "David Greenman" at Mar 17, 95 06:35:59 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Content-Length: 1490 Sender: cvs-sys-owner@freebsd.org Precedence: bulk > > >>> > has moved to (repository copy). > >>> > >>> Why? > >>> > >>because we have no /usr/include/libkern.h > > > >But we have . > > > >Why do we have a libkern/inet_ntoa.c that is not the same as > >libc/net/inet_ntoa.c? libkern is supposed to contain copies of library > >source files. > > NOT! IMNSHO, copying files out of libc for the kernel is extremely evil. That was what Berkeley intended when they did this, if you have doubts go read /usr/src/lib/libc/Makefile, targets libkern:, libkern.gen, and libkern.${MACHINE}... the one of real interest here is: libkern.gen: ${KQSRCS} ${KSRCS} cp -p ${.CURDIR}/quad/quad.h ${.ALLSRC} /sys/libkern And KQSRCS and KSRCS are: KQSRCS= adddi3.c anddi3.c ashldi3.c ashrdi3.c cmpdi2.c divdi3.c iordi3.c \ lshldi3.c lshrdi3.c moddi3.c muldi3.c negdi2.c notdi2.c qdivrem.c \ subdi3.c ucmpdi2.c udivdi3.c umoddi3.c xordi3.c KSRCS= bcmp.c ffs.c index.c mcount.c rindex.c strcat.c strcmp.c strcpy.c \ strlen.c strncpy.c inet_ntoa.c was recently added by Garrett, who probably did not know to go update these unused rules in libc/Makefile. It also appears that Garrett wrote they one in libkern from scratch and is claiming copy right on it, and from looking at the two he has a right to that copyright. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD