From owner-svn-src-head@FreeBSD.ORG Thu Jul 25 09:36:49 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A6FF55F0; Thu, 25 Jul 2013 09:36:49 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: from mail-la0-x22f.google.com (mail-la0-x22f.google.com [IPv6:2a00:1450:4010:c03::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C162D2B58; Thu, 25 Jul 2013 09:36:48 +0000 (UTC) Received: by mail-la0-f47.google.com with SMTP id fe20so1160046lab.6 for ; Thu, 25 Jul 2013 02:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=xeqo7JWFg630vQVxmen26eMe7/+n5tYfj2ttBX/HS1o=; b=Vz+StGlsdSLb1sdgQE+YlliInMEsVoP/6GZX0Pa/3rPS2rcY00K/5csybscYVL4/Ou LvtANweJ1EBpudP8GRmJF/PDaQRzMsx3MezA7Q8pfElRw87HA5xedpqtMQa54O7ojaV0 hD5TM8nmJ5DTuZPdytglvsdMwGTLDX/vf0rv3xtYapT8OI9rCQIPuIFXVtkZIcLkb5Es uyQ76I0jqUU/D016L1n6Z7HDij30+6HunOxKzWzO9bfK9eqcc5uZyZIeawOm51jTHa6z DD6nfPFEkD7RAJUhRM6r8laPexvP9Jzx+xiqn1T6NCPGMe4AQ38pGgsuiWBf7GC4IOK3 8vEQ== MIME-Version: 1.0 X-Received: by 10.152.87.194 with SMTP id ba2mr19089614lab.6.1374745006185; Thu, 25 Jul 2013 02:36:46 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.149.38 with HTTP; Thu, 25 Jul 2013 02:36:46 -0700 (PDT) In-Reply-To: <20130725080758.GE948@alchemy.franken.de> References: <201307150132.r6F1WttU081255@svn.freebsd.org> <20130725080758.GE948@alchemy.franken.de> Date: Thu, 25 Jul 2013 02:36:46 -0700 X-Google-Sender-Auth: f2UuBsbDDZ_kAdf09eUtFKaSDLc Message-ID: Subject: Re: svn commit: r253346 - in head/sys: kern net netgraph netgraph/bluetooth/socket From: Craig Rodrigues To: Marius Strobl Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jul 2013 09:36:49 -0000 On Thu, Jul 25, 2013 at 1:07 AM, Marius Strobl wrote: > > Uhm - do we really need to have that layering violation in subr_bus.c? > Wouldn't it be sufficient to set curthread->td_vnet to vnet0 in if_alloc(9) > or if_attach(9) at least instead? > There was some discussion about this involving Marko Zec, Adrian Chadd, and myself starting in this thread: http://lists.freebsd.org/pipermail/svn-src-all/2013-July/071798.html Adrian and Marko converged on similar patches: http://lists.freebsd.org/pipermail/freebsd-hackers/2012-November/041120.html http://people.freebsd.org/~adrian/ath/20130712-vimage-default-attach-detach.diff As Marko mentioned in another e-mail on this thread, the patch as it is necessary in order to fix VIMAGE related kernel panics in many different scenarios, including ones involving Netgraph nodes. -- Craig