From owner-svn-src-head@FreeBSD.ORG  Thu Oct  1 14:03:22 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 882FA1065693;
	Thu,  1 Oct 2009 14:03:22 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 466778FC15;
	Thu,  1 Oct 2009 14:03:22 +0000 (UTC)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id 719C16D41B;
	Thu,  1 Oct 2009 14:03:20 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 5150F844E4; Thu,  1 Oct 2009 16:03:20 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Coleman Kane <cokane@FreeBSD.org>
References: <200910010243.n912hpSM034846@svn.freebsd.org>
	<86eipno12p.fsf@ds4.des.no> <1254401817.4255.14.camel@localhost>
Date: Thu, 01 Oct 2009 16:03:20 +0200
In-Reply-To: <1254401817.4255.14.camel@localhost> (Coleman Kane's message of
	"Thu, 01 Oct 2009 08:56:57 -0400")
Message-ID: <86ab0bnrdj.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.95 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	"Bjoern A. Zeeb" <bz@FreeBSD.org>, src-committers@freebsd.org
Subject: Re: svn commit: r197654 - head/sys/dev/if_ndis
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Oct 2009 14:03:22 -0000

Coleman Kane <cokane@FreeBSD.org> writes:
> Thanks, fix committed... I know style(9) says I should have not bothered
> with the commit, but the assume-that-zero-is-false logic seemed
> egregious enough at the time to warrant correcting it.

Depends.  Is ndis_80211 purely a boolean value?  If yes, it should
probably be a bit field; if no, style(9) clearly says that you should
use an explicit comparison.

(a quick perusal of the source says it isn't, so an explicit comparison
is required)

> I just corrected it improperly in my haste. Enjoy being able to
> buildkernel again. I'll be sitting in the corner.

Don't worry, you'll be in good company there :)

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no