From nobody Mon Feb 2 22:42:40 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f4hTD2FJWz6Qdp5 for ; Mon, 02 Feb 2026 22:42:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f4hTD1cQQz4LLZ for ; Mon, 02 Feb 2026 22:42:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770072160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RSpshKMvW/ImQ1w8xMjRUWtdFvrQVooFF7pVnhIu7aI=; b=p+5Q3xwhChVHqta6z6PepNs6pPwNUDqZfPVgI/iEeZcrh5nD/vx5bIZOkHzyEhlzrJexIx KJgVJqiw4TOOE6XeRMYIkxe313g/ftQUoNMgHSZB/RTjOwBHuYhJdMEmk9j+XPtsoKH4mt dqugJEXwRrHse9m7UTTlKUTsbgKNOlCgU+/5+nzuqAJcn5hfAAK2+1nJWtVdGvNukktMw+ MMK/2r9irm2vGiOfABiOyUZDzoX+9VITclaRQo092k3OZJDpE6cI8Onl+Pf9HLpUJvjJmG U/G85zqoOifVt0rNh0vuiRum4bfw3vrJdLKhEukSDmVNYR0qfmtzudbAd9exrQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770072160; a=rsa-sha256; cv=none; b=oN4Yi5xna8TXUBb/8rhsDKCbWkjMw7amOBjyU3N3i2UeGCaJHWTZPE/q6Asj+yH1GQFhpi C3qVaMz9c7gRXtPkj7pXhnchmauuffX8O/RGCbU8iwKKHg7/2QoblZ3QXBOY3KcimZLejr marl5p8XZn5zTVmDW5Ws6o/3oPN4bLZ56e+oci3+PkY9Bz0EacZ27aSZzc13cm6IlXPSSe DJnUTZNicot8xHxf7HiBodUHfECpzGOvDsbfQ6Lcv1fkr+fR91kNOpNlo6gKHLMERJ5XUu u23tx3ceoXEpBDT4X/VXcfdiCt2sY9O90+jn9ZKVdEC1A158io0kkA5/l1Xgiw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770072160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RSpshKMvW/ImQ1w8xMjRUWtdFvrQVooFF7pVnhIu7aI=; b=gBEl7NM+lN9CXrUlzyTeg3f+39Y5zLuFaUFIoqUnEHvQworK6W7gNvQSdt4bABzHpYL3ix gw7Wfl+NngPlbryp5V6CNbPqrZiTZT1p8N7OYTzVzYAsFJlvt5SLEWvfy1e7j+jg2j19eV 8m2riCo5SHvyBHsKPZtNfvl3bC7fzsNfy9/1f99chTVCdSaB+Av7Gl1Yys/szG4uufDeqv 6a9D7YDenRP2mosHPT0jFm5tTNDfjBAF0sF/U7WGeuVcILMoybGIpMHkPtmm5HzV1iRdaw YVoTsvKAs4d9viE9MGSnUL2mM2iYZonetHbFZHvZodTqpF2DFg7wAuuMjlZA1Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f4hTD11jpzmLm for ; Mon, 02 Feb 2026 22:42:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 19286 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 02 Feb 2026 22:42:40 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Warner Losh From: Enji Cooper Subject: git: fc0c9210cca7 - stable/15 - iicbb: Fix gcc12 complaint List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: fc0c9210cca7a8ed0b3dde92ddbe625dd794ab3c Auto-Submitted: auto-generated Date: Mon, 02 Feb 2026 22:42:40 +0000 Message-Id: <69812860.19286.365b2e68@gitrepo.freebsd.org> The branch stable/15 has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=fc0c9210cca7a8ed0b3dde92ddbe625dd794ab3c commit fc0c9210cca7a8ed0b3dde92ddbe625dd794ab3c Author: Warner Losh AuthorDate: 2025-09-14 17:12:38 +0000 Commit: Enji Cooper CommitDate: 2026-02-02 22:42:21 +0000 iicbb: Fix gcc12 complaint So gcc12 doesn't understand that t->udelay is >= 1, so thinks that noack might be unset sometimes. While we specifically constrain this on direct assignment, there's a sysctl that might not. This is likely also a bug. Instead of uglifying everything by using MAX(1, sc->udelay), I rewrote the for loop as a do-while loop (which arguably dictates intent better because this code clearly assumes it will be executed once). Sponsored by: Netflix (cherry picked from commit 4b301f7e7ab43bb61561786c2ab33f3a3c4a725d) --- sys/dev/iicbus/iicbb.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sys/dev/iicbus/iicbb.c b/sys/dev/iicbus/iicbb.c index c344bda930b0..5f6423135f46 100644 --- a/sys/dev/iicbus/iicbb.c +++ b/sys/dev/iicbus/iicbb.c @@ -331,7 +331,7 @@ iicbb_getack(device_t dev) { struct iicbb_softc *sc = device_get_softc(dev); int noack, err; - int t; + int t = 0; /* Release SDA so that the slave can drive it. */ err = iicbb_clockin(dev, 1); @@ -341,12 +341,13 @@ iicbb_getack(device_t dev) } /* Sample SDA until ACK (low) or udelay runs out. */ - for (t = 0; t < sc->udelay; t++) { + do { noack = I2C_GETSDA(dev); if (!noack) break; DELAY(1); - } + t++; + } while(t < sc->udelay); DELAY(sc->udelay - t); iicbb_clockout(dev);