From nobody Tue Jan 7 14:30:24 2025 X-Original-To: wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YSD3k1Y4tz5kds2 for ; Tue, 07 Jan 2025 14:30:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YSD3k0QwNz4Hls for ; Tue, 7 Jan 2025 14:30:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736260226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VAvJ3SwiEe1SlepAySz2/pDOMV75X9CXnMIHMMVySF4=; b=dv4AjBBZJsIkdn/r44p68TxpqowF6m82VvEpEvMRSOeInU5sVoZRLbiyrb1B1HRjasbspE 9Zff7defTwrqFfpSS2GoNhbJLqR7jSV7HDmTbMvSswxw8NCGCXVbfvDZzGiuNLF1NGVGSv nM+jxGONULUO1szsPsCj90XKw7UnUqRU4M1apvCMZPGV8jChHQfEj9ul2oYYsdo576c5mP RmOJBU8cY4hHdDtSqRLFqSdT9ZE4xLXI4LB26evLQOZcE0GkGOaajwcRu/mOpUosCYsegW hORuBxGMbsjH3kvKghkzY8KNtpO6H1T4frMev5xsiHxYRL4KYIVvwD5iiJFpwQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736260226; a=rsa-sha256; cv=none; b=vlDyAD1HX1UygHDdrfoQ92UM/4yl2/v3mjwv1j8dyQzOs4zS+veeMsmfhSr+0g63Ptai78 AdSBbA8h94HIWHTQ5v8xUJlw0JLSua0BFsjsS7Rbn74ZfgRFbUnCWoLboWvK9bX/4VOqCn g1iCNRnqL/k9Lgq7BO3/U3Qi+cGk4hopbfd9EZK9s4HIS+WD50NLxFPI1ln0BTd299X55C ftHE5jZIGzR2u1Omw5J4GL2XU0HxAtBHeQgWaX9CUZmDB6uIM+BmQfyAYc7mX0RatJEGms b7PHaEFFORAQ+mHRsAaTjvJJMM0XgFAp5AK0sVEwwKdY64F8jQZhRlVSDXgViw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YSD3k00ZDz1CkX for ; Tue, 07 Jan 2025 14:30:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 507EUPYt092624 for ; Tue, 7 Jan 2025 14:30:25 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 507EUPSJ092623 for wireless@FreeBSD.org; Tue, 7 Jan 2025 14:30:25 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 283142] rtw88: does not connect to network [was: Error when connecting to WiFi | Invalid argument in wpa_supplicant] Date: Tue, 07 Jan 2025 14:30:24 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: 14.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bz@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-wireless@freebsd.org Sender: owner-freebsd-wireless@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283142 --- Comment #22 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D2372f8cc640c2f4ab82831e6ac0e27ab6= c18321a commit 2372f8cc640c2f4ab82831e6ac0e27ab6c18321a Author: Bjoern A. Zeeb AuthorDate: 2024-12-20 14:23:50 +0000 Commit: Bjoern A. Zeeb CommitDate: 2025-01-07 14:26:17 +0000 LinuxKPI 802.11 / rtw88: make packets flow again In 886653492945f we added checks for packets to only go out if the station is known to the firmware (amongst others) as there are implications in drivers. Unfortunately rtw88 does not support the mac80211 (*sta_state)() KPI but only the fallback (*sta_add/remove)() in which case the station is only added to firmware when going from AUTH to ASSOC. That means we had no chance to get authenticated anymore. The problem has existed since June in main and stable/14 but only now was noticed in December with 14.2-R which makes me wonder. I am still not entirely sure what implications the missing checks have on all the other drivers using (*sta_state)() (or if they were really needed in first place beyond txq_ready) but I have run a few days of iwlwifi with this without extra trouble but I was not always able to reproduce problems in the past. Also people are occasionally still reporting the original "Invalid TXQ" error which indicates there is another lingering case somewhere. For the moment make rtw88 work again and expose the change to a wider audience. PR: 283142, 274382 Fixes: 886653492945f (make sure we can send DISASSOC or DEAUTH frames) Tested by: imb protected-networks.net, oleg.nauman gmail.com Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D48161 sys/compat/linuxkpi/common/src/linux_80211.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) --=20 You are receiving this mail because: You are on the CC list for the bug.=