From owner-svn-src-head@freebsd.org Mon Jan 15 06:37:16 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F3F3DEB26CC for ; Mon, 15 Jan 2018 06:37:15 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-it0-f47.google.com (mail-it0-f47.google.com [209.85.214.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C4D9C81F4F for ; Mon, 15 Jan 2018 06:37:15 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-it0-f47.google.com with SMTP id b77so15503933itd.0 for ; Sun, 14 Jan 2018 22:37:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:cc; bh=oX7DUBtiLYEfkrrXGHWcWDuxqoLrGv0pEEaiBgeuvp8=; b=KyQT1a+lXES4+ct7GwXq5QbMeNbj4sJ9GOg7+BblUXBD6fDQZoHomyNVh6u2wPPmyF dTbBaJmXyMoy6WnCaNJIQxWsXiUv9uYyDkaYmxsUb9hdaB3TTW4NUOgUfYp/SB8tk7zz +XifazTH2HZi9BB1Zj72q52XKg5oPRK9nmNpjrnwp3/IRlIqbzNU2mc9QOuhhN6aO/VT v4LyC8nBpM1/saNQ6XfyKfridaHQdB/2/Wx9aIe4Pu37MAY89qkzXoimYwx36ufclDN4 qCXQGzlDpWmqOIrtNzij6/brYjY4j+sRuLuvlkn58MmtIP4h3CoFofI9lGs1yuIm6gcu ZSrw== X-Gm-Message-State: AKwxytfnNb2kcAh2k5LYpaOxwy2ryI4ViWThQ/kaTYY+8ru/pu/t9Kiu Q0HFZutAHUuu2fIiRTTpsJ8l5LIV X-Google-Smtp-Source: ACJfBovU773Ypk8riqt3p3SIx194nWnLM4UM945hKbUc7uURuRmHm2w0vUJ+3Tb5KWVkcYhUBdZg9Q== X-Received: by 10.36.208.72 with SMTP id m69mr12089333itg.73.1515996975147; Sun, 14 Jan 2018 22:16:15 -0800 (PST) Received: from mail-io0-f173.google.com (mail-io0-f173.google.com. [209.85.223.173]) by smtp.gmail.com with ESMTPSA id e20sm15363986ioe.13.2018.01.14.22.16.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Jan 2018 22:16:14 -0800 (PST) Received: by mail-io0-f173.google.com with SMTP id f6so11950789ioh.8 for ; Sun, 14 Jan 2018 22:16:14 -0800 (PST) X-Received: by 10.107.5.142 with SMTP id 136mt37627250iof.239.1515996974490; Sun, 14 Jan 2018 22:16:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.149.147 with HTTP; Sun, 14 Jan 2018 22:15:54 -0800 (PST) In-Reply-To: <201801150500.w0F50RGV047396@repo.freebsd.org> References: <201801150500.w0F50RGV047396@repo.freebsd.org> From: Kyle Evans Date: Mon, 15 Jan 2018 00:15:54 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r327991 - head/stand/fdt Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 06:37:16 -0000 On Sun, Jan 14, 2018 at 11:00 PM, Kyle Evans wrote: > Author: kevans > Date: Mon Jan 15 05:00:26 2018 > New Revision: 327991 > URL: https://svnweb.freebsd.org/changeset/base/327991 > > Log: > stand/fdt: don't send clobbered FDT to the kernel > > If fdt_overlay_apply fails at some stage to apply the overlay to the base, > both the base and overlay may be in an inconsistent state (some fixups > applied, some phandles adjusted, some symbols merged). These can be bad for > a number of reasons, to include user frustration if some fixups applied and > not others. Fail a little safer by making a clean copy of the base FDT for > every overlay that we can simply discard if things go awry. > > This also allows us the luxury of simply discarding overlays if we hit some > kind of memory limit or if they're malformed and extremely large for some > reason. We'll now leave a nice error message indicating that some overlays > could not be applied due to size restrictions and we apply what we can. > > I note that our overlay implementation has some flaws that might still leave > your system in an unbootable state even if an overlay applies correctly; > please exercise caution in using overlays until we can swap it out for > libfdt's implementation. > > Tested on: BananaPi-M3 (armv7) > Tested on: Pine64 (aarch64) > Differential Revision: https://reviews.freebsd.org/D13709 > I seem to have droppped this: MFC after: 1 week