From owner-svn-src-head@FreeBSD.ORG Wed May 20 19:29:52 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EC5BF106566B; Wed, 20 May 2009 19:29:52 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-px0-f106.google.com (mail-px0-f106.google.com [209.85.216.106]) by mx1.freebsd.org (Postfix) with ESMTP id B83DF8FC0A; Wed, 20 May 2009 19:29:52 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: by pxi4 with SMTP id 4so554490pxi.3 for ; Wed, 20 May 2009 12:29:52 -0700 (PDT) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.142.52.7 with SMTP id z7mr584140wfz.211.1242847792223; Wed, 20 May 2009 12:29:52 -0700 (PDT) In-Reply-To: <200905201858.n4KIw7Fc040619@svn.freebsd.org> References: <200905201858.n4KIw7Fc040619@svn.freebsd.org> From: Juli Mallett Date: Wed, 20 May 2009 12:29:32 -0700 X-Google-Sender-Auth: 1de2fcd3fffde353 Message-ID: To: Rick Macklem Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r192463 - head/sys/fs/nfsserver X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2009 19:29:53 -0000 When client ids have been run out of, does that put something into a dangerous state (insecure or crash-prone)? Isn't it better to let the administrator make the decision of when to reboot the machine? On Wed, May 20, 2009 at 11:58 AM, Rick Macklem wrote= : > Author: rmacklem > Date: Wed May 20 18:58:07 2009 > New Revision: 192463 > URL: http://svn.freebsd.org/changeset/base/192463 > > Log: > =A0Although it should never happen, all the nfsv4 server can do > =A0when it runs out of clientids is reboot. I had replaced cpu_reboot() > =A0with printf(), since cpu_reboot() doesn't exist for sparc64. > =A0This change replaces the printf() with panic(), so the reboot > =A0would occur for this highly unlikely occurrence. > > =A0Approved by: =A0kib (mentor) > > Modified: > =A0head/sys/fs/nfsserver/nfs_nfsdstate.c > > Modified: head/sys/fs/nfsserver/nfs_nfsdstate.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/fs/nfsserver/nfs_nfsdstate.c =A0 =A0 =A0 Wed May 20 18:45:49= 2009 =A0 =A0 =A0 =A0(r192462) > +++ head/sys/fs/nfsserver/nfs_nfsdstate.c =A0 =A0 =A0 Wed May 20 18:58:07= 2009 =A0 =A0 =A0 =A0(r192463) > @@ -3709,7 +3709,7 @@ nfsrv_nextclientindex(void) > =A0 =A0 =A0 =A0 * In practice, we'll never get here, but the reboot is he= re, > =A0 =A0 =A0 =A0 * just for fun. (client_index will not wrap around on any= real server) > =A0 =A0 =A0 =A0 */ > - =A0 =A0 =A0 printf("you must reboot now\n"); > + =A0 =A0 =A0 panic("nfsv4 server out of clientids"); > =A0 =A0 =A0 =A0return (0); =A0 =A0 /* Just to shut the compiler up */ > =A0} > >