From owner-freebsd-bugs@FreeBSD.ORG Thu Sep 29 16:50:12 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D6A8A16A41F for ; Thu, 29 Sep 2005 16:50:12 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 87A5943D49 for ; Thu, 29 Sep 2005 16:50:12 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j8TGoCZ8067609 for ; Thu, 29 Sep 2005 16:50:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j8TGoCQa067608; Thu, 29 Sep 2005 16:50:12 GMT (envelope-from gnats) Date: Thu, 29 Sep 2005 16:50:12 GMT Message-Id: <200509291650.j8TGoCQa067608@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Giorgos Keramidas Cc: Subject: Re: bin/86710: Update bin/ls to have option to cancel -A with super user X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Giorgos Keramidas List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2005 16:50:13 -0000 The following reply was made to PR bin/86710; it has been noted by GNATS. From: Giorgos Keramidas To: Marcus Alves Grando Cc: FreeBSD-gnats-submit@freebsd.org Subject: Re: bin/86710: Update bin/ls to have option to cancel -A with super user Date: Thu, 29 Sep 2005 19:48:33 +0300 On 2005-09-29 11:50, Marcus Alves Grando wrote: > + /* Root is -A automatically. */ > + if (!getuid() && !f_nolistdot) > + f_listdot = 1; > + If you are going to touch this check, then please change it to avoid the use of the !condition idiom :) if (getuid() == 0 && f_nolistdot == 0) f_listdot = 1;