From owner-freebsd-tinderbox@FreeBSD.ORG Mon May 2 16:19:25 2011 Return-Path: Delivered-To: tinderbox@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D5D84106566B; Mon, 2 May 2011 16:19:25 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 64D678FC0A; Mon, 2 May 2011 16:19:24 +0000 (UTC) Received: by vws18 with SMTP id 18so5759088vws.13 for ; Mon, 02 May 2011 09:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=vNSl1WipaBpWUfxOLWA1kB5iOSA7kUs6TTsxC9KwTes=; b=aXhD52gyG5C7IUwr2sdfysn/8xMYYM68zcNRTxJFdaCmfHKuThyzZKyDXvPFKyUoe1 Z2E0D/zbU1eg/EbQkFbetZenadDAI358ucwBbfKt96suECRW2LHRWd8cVi+NJqpYoJEx 5iqDiS9iAE6wYfxBitRKo/oYvPTPHXMXhsWjw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=t8WEMSSwAZKSj4DU/xhq+m1pm9fwdWq/SRG91DwsTnso3VtrZwDToE0YI+nCJWc7lz zThGFBSKgDXVHlTNm/cduIuDgtgdDQIs/6uR3PUOfwIXtzOHEO4yChbqx2KuiPUfi5AO DjFL8O29p6opRACck7IFLolCASO520MfB9JpA= MIME-Version: 1.0 Received: by 10.220.112.138 with SMTP id w10mr1710906vcp.46.1304351670757; Mon, 02 May 2011 08:54:30 -0700 (PDT) Received: by 10.220.199.130 with HTTP; Mon, 2 May 2011 08:54:30 -0700 (PDT) In-Reply-To: <201105020748.p427mBRP004105@freebsd-current.sentex.ca> References: <201105020748.p427mBRP004105@freebsd-current.sentex.ca> Date: Mon, 2 May 2011 08:54:30 -0700 Message-ID: From: Garrett Cooper To: FreeBSD Tinderbox Content-Type: multipart/mixed; boundary=0016e6471744ff6a8804a24d09fa Cc: freebsd-hackers@freebsd.org, current@freebsd.org, i386@freebsd.org Subject: Re: [head tinderbox] failure on i386/i386 X-BeenThere: freebsd-tinderbox@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Tinderbox reports, responses, and meta-comments" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 16:19:25 -0000 --0016e6471744ff6a8804a24d09fa Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Mon, May 2, 2011 at 12:48 AM, FreeBSD Tinderbox wrote: [...] > cc -c -O -pipe =A0-std=3Dc99 -g -Wall -Wredundant-decls -Wnested-externs = -Wstrict-prototypes =A0-Wmissing-prototypes -Wpointer-arith -Winline -Wcast= -qual =A0-Wundef -Wno-pointer-sign -fformat-extensions -nostdinc =A0-I. -I/= src/sys -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -inc= lude opt_global.h -fno-common -finline-limit=3D8000 --param inline-unit-gro= wth=3D100 --param large-function-growth=3D1000 =A0-mno-align-long-strings -= mpreferred-stack-boundary=3D2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-s= se3 -msoft-float -ffreestanding -fstack-protector -Werror =A0/src/sys/dev/l= ge/if_lge.c > cc -c -O -pipe =A0-std=3Dc99 -g -Wall -Wredundant-decls -Wnested-externs = -Wstrict-prototypes =A0-Wmissing-prototypes -Wpointer-arith -Winline -Wcast= -qual =A0-Wundef -Wno-pointer-sign -fformat-extensions -nostdinc =A0-I. -I/= src/sys -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -inc= lude opt_global.h -fno-common -finline-limit=3D8000 --param inline-unit-gro= wth=3D100 --param large-function-growth=3D1000 =A0-mno-align-long-strings -= mpreferred-stack-boundary=3D2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-s= se3 -msoft-float -ffreestanding -fstack-protector -Werror =A0/src/sys/dev/m= alo/if_malo.c > cc -c -O -pipe =A0-std=3Dc99 -g -Wall -Wredundant-decls -Wnested-externs = -Wstrict-prototypes =A0-Wmissing-prototypes -Wpointer-arith -Winline -Wcast= -qual =A0-Wundef -Wno-pointer-sign -fformat-extensions -nostdinc =A0-I. -I/= src/sys -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -inc= lude opt_global.h -fno-common -finline-limit=3D8000 --param inline-unit-gro= wth=3D100 --param large-function-growth=3D1000 =A0-mno-align-long-strings -= mpreferred-stack-boundary=3D2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-s= se3 -msoft-float -ffreestanding -fstack-protector -Werror =A0/src/sys/dev/m= alo/if_malohal.c > cc -c -O -pipe =A0-std=3Dc99 -g -Wall -Wredundant-decls -Wnested-externs = -Wstrict-prototypes =A0-Wmissing-prototypes -Wpointer-arith -Winline -Wcast= -qual =A0-Wundef -Wno-pointer-sign -fformat-extensions -nostdinc =A0-I. -I/= src/sys -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -inc= lude opt_global.h -fno-common -finline-limit=3D8000 --param inline-unit-gro= wth=3D100 --param large-function-growth=3D1000 =A0-mno-align-long-strings -= mpreferred-stack-boundary=3D2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-s= se3 -msoft-float -ffreestanding -fstack-protector -Werror =A0/src/sys/dev/m= alo/if_malo_pci.c > cc1: warnings being treated as errors > /src/sys/dev/malo/if_malo_pci.c: In function 'malo_pci_attach': > /src/sys/dev/malo/if_malo_pci.c:232: warning: large integer implicitly tr= uncated to unsigned type > /src/sys/dev/malo/if_malo_pci.c:232: warning: large integer implicitly tr= uncated to unsigned type > *** Error code 1 > > Stop in /obj/i386.i386/src/sys/PAE. > *** Error code 1 > > Stop in /src. > *** Error code 1 > > Stop in /src. Tinderbox has been whining about malo for the last day or so on i386 because of this issue. Could someone please commit the following patch to fix it? It's correct according to the printf(3) manpage combined with the fields in the malo_hal structure. FWIW I'm a bit confused too because it's listed in the WITHOUT_MODULES group for several i386 kernel compiles based on my looking at the make universe output, but it's still barfing on the module with tinderbox (and not with my local make universe), but it the results might be tainted by my environment somehow. Thanks! -Garrett --0016e6471744ff6a8804a24d09fa Content-Type: text/x-patch; charset=US-ASCII; name="fix-sys-dev-if-malo-format-string.patch" Content-Disposition: attachment; filename="fix-sys-dev-if-malo-format-string.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gn7bwhqy1 SW5kZXg6IHN5cy9kZXYvbWFsby9pZl9tYWxvLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL2Rldi9tYWxv L2lmX21hbG8uYwkocmV2aXNpb24gMjIxMjE5KQorKysgc3lzL2Rldi9tYWxvL2lmX21hbG8uYwko d29ya2luZyBjb3B5KQpAQCAtMjI0LDkgKzIyNCw5IEBACiAJfQogCiAJRFBSSU5URihzYywgTUFM T19ERUJVR19GVywKLQkgICAgIm1hbG9faGFsX2dldGh3c3BlY3M6IGh3dmVyc2lvbiAweCV4IGhv c3RpZiAweCV4IgotCSAgICAibWF4bnVtX3djYiAweCV4IG1heG51bV9tY2FkZHIgMHgleCBtYXhu dW1fdHhfd2NiIDB4JXgiCi0JICAgICJyZWdpb25jb2RlIDB4JXggbnVtX2FudGVubmEgMHgleCBm d19yZWxlYXNlbnVtIDB4JXgiCisJICAgICJtYWxvX2hhbF9nZXRod3NwZWNzOiBod3ZlcnNpb24g MHglaGh4IGhvc3RpZiAweCVoaHgiCisJICAgICJtYXhudW1fd2NiIDB4JWh4IG1heG51bV9tY2Fk ZHIgMHglaHggbWF4bnVtX3R4X3djYiAweCVoeCIKKwkgICAgInJlZ2lvbmNvZGUgMHglaHggbnVt X2FudGVubmEgMHglaHggZndfcmVsZWFzZW51bSAweCV4IgogCSAgICAid2NiYmFzZTAgMHgleCBy eGRlc2NfcmVhZCAweCV4IHJ4ZGVzY193cml0ZSAweCV4IgogCSAgICAidWxfZndfYXdha2Vjb29r aWUgMHgleCB3WzRdID0gJXggJXggJXggJXgiLAogCSAgICBzYy0+bWFsb19od3NwZWNzLmh3dmVy c2lvbiwKQEAgLTE5MzEsNyArMTkzMSw4IEBACiB7CiAJc3RydWN0IGlmbmV0ICppZnAgPSBzYy0+ bWFsb19pZnA7CiAKLQlpZl9wcmludGYoaWZwLCAidmVyc2lvbnMgW2h3ICVkIGZ3ICVkLiVkLiVk LiVkXSAocmVnaW9uY29kZSAlZClcbiIsCisJaWZfcHJpbnRmKGlmcCwKKwkJInZlcnNpb25zIFto dyAweCVoaHggZncgJWQuJWQuJWQuJWRdIChyZWdpb25jb2RlIDB4JWh4KVxuIiwKIAkJc2MtPm1h bG9faHdzcGVjcy5od3ZlcnNpb24sCiAJCShzYy0+bWFsb19od3NwZWNzLmZ3X3JlbGVhc2VudW0g Pj4gMjQpICYgMHhmZiwKIAkJKHNjLT5tYWxvX2h3c3BlY3MuZndfcmVsZWFzZW51bSA+PiAxNikg JiAweGZmLAo= --0016e6471744ff6a8804a24d09fa--