From owner-svn-src-all@freebsd.org Tue Apr 9 17:40:27 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25ED51566D0C for ; Tue, 9 Apr 2019 17:40:27 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8F82A6FF83 for ; Tue, 9 Apr 2019 17:40:26 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1554831624; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=qvXmndRPcuq7kQUMNkdAtKZwk4nM30taUX8KRihCgoCMtusuhmLLw/JJ5G4AAZpEp/dEv05NdUxRi ekWeWkz3LboZxPszgAuQeFnFVc4bHx54QH13b+X/kirBXzxI7tHbNMvZ8ZlvGx2WEiUpBRZOaqI3w6 2VFrUXa5mWbfKSyVh6UF1/zU1gEdpX80kLuYlVIrZbBvhiv2OJu5lBGPlvOPrKO8vk95p+qjAC1zmT +vP6GA0HaapoosWXLvH9s+bheZyls+qqSNODbApIEn3tXjgqYUaZJg4ZczbAWtOt522pVIEL6KysGz OMWFeXvE2zXYZsVpB5vWIw0eOCfYi+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=4tlSvX8BJlUuvPfP/Je8jbwoO19KLvks+2lUODxOA+E=; b=ksdT6s0MLxOEvynUW+Nr1owTYEPV1QAYV38wrlc7Di/Nf7g65qq2g+FBqjelzt5nRUunXWk7TGXp+ MJ8OBZRV+LHkN6xg/czLRrwZhkd/r3e6nHo/qV+B5gBXzKTUXdrdv24aRBOWXunHgV4aoygd4HQXgq 9Sx4exuvfT884B5ZTLLLtyJEvp51AqewKXgaN6B7h8XdL28mGdv6wON58t+AM/W7jveBUxpKqmJY5Y jgEBMJzV0ThCw/kEI+l1hXBpXe6S19VkWQfspCbEL0LxYNR44Zf6SWeVN8dc8pL9f0ETYevrQ/DVES fRxQR2JrfJz8hPmjasZlCmyjkMUvfPQ== ARC-Authentication-Results: i=1; outbound2.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=4tlSvX8BJlUuvPfP/Je8jbwoO19KLvks+2lUODxOA+E=; b=udTgtRaxhSDlCDHRpPsTS9kzodzGn+YdNklWQhFKBHdWQAfrPmxT7v/32P4ql8vKT5GWm2n5weDil 2z/UZgIILcmFte0SHEiM/S0agFurpkRLxQdJSkTSTGD5DSUkXA+XAoNoVWYUTmF+M6zgV8xd36/l/d Qk/Uv8KznqR76T7pYpRx2ouxUIF4owtI0GFOlQlRt2+eZn9khqrXfc8nNGAjAP9Re1QNFssDj88dCv hAnQD6y+bAEiOu6se6OFdS00Hvsc4wGufdof1hRUFSat0cBBUNIrmp84rOlevxifxpkQeYJSfB5/2z JFqqlZ1IOdONcXOas51qeybsMzMeCag== X-MHO-RoutePath: aGlwcGll X-MHO-User: 8b1ada05-5aee-11e9-803b-31925da7267c X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.eu.mailhop.org (Halon) with ESMTPSA id 8b1ada05-5aee-11e9-803b-31925da7267c; Tue, 09 Apr 2019 17:40:20 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x39HeJUe018180; Tue, 9 Apr 2019 11:40:19 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r346039 - head/sys/conf From: Ian Lepore To: Rebecca Cran , Warner Losh , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Tue, 09 Apr 2019 11:40:19 -0600 In-Reply-To: References: <201904081825.x38IPEpV054311@repo.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8F82A6FF83 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.990,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 17:40:27 -0000 On Tue, 2019-04-09 at 11:19 -0600, Rebecca Cran wrote: > On 2019-04-08 12:25, Warner Losh wrote: > > Author: imp > > Date: Mon Apr 8 18:25:14 2019 > > New Revision: 346039 > > URL: https://svnweb.freebsd.org/changeset/base/346039 > > > > Log: > > Style only change: Prefer $() to `` > > > > $() is more modern and also nests. Convert the mix of styles to > > using > > only the former (although the latter was more common). It's the > > more > > dominant style in other shell scripts these days as well. > > > > Differential Revision: https://reviews.freebsd.org/D19840 > > > > Modified: > > head/sys/conf/newvers.sh > > > > Modified: head/sys/conf/newvers.sh > > > I thought I saw an email a few weeks ago that suggested that the list > of > people who reviewed the patch should be copied into a "Reviewed by:" > line, to avoid only having that information in Phabricator. > > Am I remembering correctly, or is just mentioning the Phab review > considered sufficient? > > As far as I'm concerned, if I've gone to all the trouble to have something phab-reviewed, I'm not going to waste a bunch of time hand- copying metadata from the review to the commit message; citing the review is sufficient. -- Ian