Date: Mon, 20 Feb 2023 19:41:21 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Kyle Evans <kevans@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: cd73914b01a1 - main - kern: physmem: don't truncate addresses in DEBUG output Message-ID: <870983EF-591C-4685-A133-1E0E37CF0B98@freebsd.org> In-Reply-To: <202302201855.31KItK45079891@gitrepo.freebsd.org> References: <202302201855.31KItK45079891@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 Feb 2023, at 18:55, Kyle Evans <kevans@FreeBSD.org> wrote: >=20 > The branch main has been updated by kevans: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dcd73914b01a1f2300e587f802383cc56= 3f2e7103 >=20 > commit cd73914b01a1f2300e587f802383cc563f2e7103 > Author: Kyle Evans <kevans@FreeBSD.org> > AuthorDate: 2023-02-20 18:54:00 +0000 > Commit: Kyle Evans <kevans@FreeBSD.org> > CommitDate: 2023-02-20 18:55:04 +0000 >=20 > kern: physmem: don't truncate addresses in DEBUG output >=20 > Make it consistent with the above region printing, otherwise it = appears > to be somewhat confusing. > --- > sys/kern/subr_physmem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/sys/kern/subr_physmem.c b/sys/kern/subr_physmem.c > index bb6af5a580aa..d371e1e166c5 100644 > --- a/sys/kern/subr_physmem.c > +++ b/sys/kern/subr_physmem.c > @@ -149,10 +149,10 @@ physmem_dump_tables(int (*prfunc)(const char *, = ...)) > #ifdef DEBUG > prfunc("Avail lists:\n"); > for (i =3D 0; phys_avail[i] !=3D 0; ++i) { > - prfunc(" phys_avail[%d] 0x%08x\n", i, phys_avail[i]); > + prfunc(" phys_avail[%d] 0x%08jx\n", i, phys_avail[i]); You need to actually cast them though for 32-bit. Jess > } > for (i =3D 0; dump_avail[i] !=3D 0; ++i) { > - prfunc(" dump_avail[%d] 0x%08x\n", i, dump_avail[i]); > + prfunc(" dump_avail[%d] 0x%08jx\n", i, dump_avail[i]); > } > #endif > }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?870983EF-591C-4685-A133-1E0E37CF0B98>