From owner-freebsd-scsi@freebsd.org Tue Mar 21 16:06:14 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 074E0D169AA for ; Tue, 21 Mar 2017 16:06:14 +0000 (UTC) (envelope-from stephen.mcconnell@broadcom.com) Received: from mail-io0-x233.google.com (mail-io0-x233.google.com [IPv6:2607:f8b0:4001:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D1F3912E4 for ; Tue, 21 Mar 2017 16:06:13 +0000 (UTC) (envelope-from stephen.mcconnell@broadcom.com) Received: by mail-io0-x233.google.com with SMTP id b140so51325583iof.1 for ; Tue, 21 Mar 2017 09:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to; bh=g4FefZWalMGZH7h7YZVJAnACevNMUfQY2qWp2U2NR8M=; b=Y2nHpfR6Jp9pVmCNLpbLQ6wJBUJSBtQEu9doSbO8nVLPri0JRlwneZhLatKnKABKMF Jpenfds78sp3HjItzKpTNc/UI0pOvuobU8pVTH7SLzQXHL/MLHiUlapeg+izzgCbrm2Q U8nxhvoSJlXHd0TxkDaq78Dv5MWK4KKJIX0so= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to; bh=g4FefZWalMGZH7h7YZVJAnACevNMUfQY2qWp2U2NR8M=; b=GBb0grDW14e9pYHaLMnP5x76j0Jr5DMAsI2y2GBCJUwz29vSXQa/LlL9ANrON9xo6e pI42cXuDNIYNKzqBUCB4ShxWY8EzUpTnUx5bA3wf5zuS/2XRYIArierf8jOXxpLGh+Ms oyYEe7pbInJXT8Z9soTVLSv9SxQugOZWsfwJi/VUWtlpiYlbRFljW/aVcagjfEN3DvSp aXTocdwfUandlSajKhvGnMa0WgX8Es1bgnWjxEW+Huj5Uf2X293m5ZEu5D3T/lQ9gcas AvuPQgQpADof+pGlw3zyawkd32rsaUXnk79Qy8xzH9+evQwFaPPssE4iw+1/0Szethga Le4w== X-Gm-Message-State: AFeK/H26mrMZx/qFFWQxi6dIiowm8i8hcVUd/rm1e8fE1+T8WWbML7hU23020UFDg09gw5Xz13XmfZIpgIwU+YDa X-Received: by 10.107.170.12 with SMTP id t12mr32307231ioe.113.1490112373080; Tue, 21 Mar 2017 09:06:13 -0700 (PDT) From: Stephen Mcconnell References: <20170321140144.GA25836@FreeBSD.org> In-Reply-To: <20170321140144.GA25836@FreeBSD.org> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQKzDrr2wDH3IFMOrbJdjTfza+PyUZ/emqdw Date: Tue, 21 Mar 2017 10:06:11 -0600 Message-ID: Subject: RE: mpr driver allocating 1 irq? To: John , FreeBSD-SCSI , scottl@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 16:06:14 -0000 I think the problem is that there is no improvement when using MSIx. scottl@ was working on a finer grained locking mechanism that would help. Maybe he can comment. Steve > -----Original Message----- > From: owner-freebsd-scsi@freebsd.org [mailto:owner-freebsd- > scsi@freebsd.org] On Behalf Of John > Sent: Tuesday, March 21, 2017 8:02 AM > To: FreeBSD-SCSI > Subject: mpr driver allocating 1 irq? > > Hi Folks, > > The following define is in sys/dev/mpr/mprvar.h: > > #define MPR_MSI_COUNT 1 > > Is there a particular reason it's hard-coded to 1 and not a tunable? > > if ((sc->disable_msix == 0) && > ((msgs = pci_msix_count(dev)) >= MPR_MSI_COUNT)) > error = mpr_alloc_msix(sc, MPR_MSI_COUNT); > > Or am I completely misreading the code? > > The code appears to support a value other than 1. > > Thanks, > John > > with verbose=1: > > mpr0: attempting to allocate 1 MSI-X vectors (96 supported) > mpr1: attempting to allocate 1 MSI-X vectors (96 supported) > mpr2: attempting to allocate 1 MSI-X vectors (96 supported) > mpr3: attempting to allocate 1 MSI-X vectors (96 supported)